From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E215C433DB for ; Fri, 26 Mar 2021 17:24:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9C3761999 for ; Fri, 26 Mar 2021 17:24:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230142AbhCZRYC (ORCPT ); Fri, 26 Mar 2021 13:24:02 -0400 Received: from mga17.intel.com ([192.55.52.151]:44195 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229986AbhCZRXx (ORCPT ); Fri, 26 Mar 2021 13:23:53 -0400 IronPort-SDR: 6dOP9eszbCFhx1HR8BVVLhHpSxB6BEqcLGwzQFvZjOdODJXJwZmI4Dwdwqg3DXGlsGcKNs6Y15 oGuDg5/1HQsw== X-IronPort-AV: E=McAfee;i="6000,8403,9935"; a="171182149" X-IronPort-AV: E=Sophos;i="5.81,281,1610438400"; d="scan'208";a="171182149" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 10:23:52 -0700 IronPort-SDR: k/GVCRLYG7QDMuSzqOUN3JK3IVXmC683HCJyssz32PB8vCFlf1962IuexFQGBq8K3vp8DT2X1O z/sVPLqw53nQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,281,1610438400"; d="scan'208";a="608947187" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 26 Mar 2021 10:23:51 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id EC86811F; Fri, 26 Mar 2021 19:24:05 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Peter Rosin Subject: [PATCH v1 1/3] mux: gpio: Use bitmap API instead of direct assignment Date: Fri, 26 Mar 2021 19:23:59 +0200 Message-Id: <20210326172401.33685-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Assigning bitmaps like it's done in the driver might be error prone. Fix this by using bitmap API. Signed-off-by: Andy Shevchenko --- drivers/mux/gpio.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c index 02c1f2c014e8..891ee0274733 100644 --- a/drivers/mux/gpio.c +++ b/drivers/mux/gpio.c @@ -6,7 +6,7 @@ * * Author: Peter Rosin */ - +#include #include #include #include @@ -23,8 +23,9 @@ static int mux_gpio_set(struct mux_control *mux, int state) { struct mux_gpio *mux_gpio = mux_chip_priv(mux->chip); DECLARE_BITMAP(values, BITS_PER_TYPE(state)); + u32 value = state; - values[0] = state; + bitmap_from_arr32(values, &value, BITS_PER_TYPE(value)); gpiod_set_array_value_cansleep(mux_gpio->gpios->ndescs, mux_gpio->gpios->desc, @@ -71,7 +72,7 @@ static int mux_gpio_probe(struct platform_device *pdev) return ret; } WARN_ON(pins != mux_gpio->gpios->ndescs); - mux_chip->mux->states = 1 << pins; + mux_chip->mux->states = BIT(pins); ret = device_property_read_u32(dev, "idle-state", (u32 *)&idle_state); if (ret >= 0 && idle_state != MUX_IDLE_AS_IS) { -- 2.30.2