From: Peter Zijlstra <peterz@infradead.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Bhaskar Chowdhury <unixbhaskar@gmail.com>,
mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, linux-kernel@vger.kernel.org,
rdunlap@infradead.org
Subject: Re: [PATCH] sched/psi.c: Rudimentary typo fixes
Date: Fri, 26 Mar 2021 19:41:22 +0100 [thread overview]
Message-ID: <20210326184122.GO4746@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <YF4hMn4rCftcdsSm@cmpxchg.org>
On Fri, Mar 26, 2021 at 02:00:18PM -0400, Johannes Weiner wrote:
> On Fri, Mar 26, 2021 at 06:12:33PM +0530, Bhaskar Chowdhury wrote:
> >
> > s/possible/possible/
> > s/ exceution/execution/
> > s/manupulations/manipulations/
> >
> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> > ---
> > kernel/sched/psi.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> > index 967732c0766c..316ebc57a115 100644
> > --- a/kernel/sched/psi.c
> > +++ b/kernel/sched/psi.c
> > @@ -59,7 +59,7 @@
> > * states, we would have to conclude a CPU SOME pressure number of
> > * 100%, since *somebody* is waiting on a runqueue at all
> > * times. However, that is clearly not the amount of contention the
> > - * workload is experiencing: only one out of 256 possible exceution
> > + * workload is experiencing: only one out of 256 possible execution
>
> I thought this was the french spelling.
>
> Joking aside, the corrections look right, but I also had no trouble
> understanding what those sentences mean. Typos happen, plus we have a
> lot of non-native speakers who won't use perfect spelling or grammar.
>
> So for me, the bar is "this can be easily understood", not "needs to
> be perfect English", and I'd say let's skip patches like these unless
> they fix something truly unintelligble.
Ignore this robot, lots of people already have a special mail rule for
him. On top of that, this spelling mistake was already fixed by Ingo in:
3b03706fa621 ("sched: Fix various typos")
Which is part of a series of such patches to head off the endless,
mindless, stream of this.
next prev parent reply other threads:[~2021-03-26 18:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 12:42 [PATCH] sched/psi.c: Rudimentary typo fixes Bhaskar Chowdhury
2021-03-26 18:00 ` Johannes Weiner
2021-03-26 18:41 ` Peter Zijlstra [this message]
2021-03-26 19:42 ` Bhaskar Chowdhury
2021-03-29 21:49 ` Shuah Khan
2021-03-26 19:39 ` Bhaskar Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210326184122.GO4746@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=unixbhaskar@gmail.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox