From: Alaa Emad <alaaemadhossney.ae@gmail.com>
To: hverkuil@xs4all.nl
Cc: gregkh@linuxfoundation.org, mchehab@kernel.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller@googlegroups.com,
Alaa Emad <alaaemadhossney.ae@gmail.com>,
syzbot+a4e309017a5f3a24c7b3@syzkaller.appspotmail.com
Subject: [PATCH v2] media: sq905.c: fix uninitialized variable
Date: Fri, 26 Mar 2021 23:02:52 +0200 [thread overview]
Message-ID: <20210326210252.129595-1-alaaemadhossney.ae@gmail.com> (raw)
Reported-by: syzbot+a4e309017a5f3a24c7b3@syzkaller.appspotmail.com
Signed-off-by: Alaa Emad <alaaemadhossney.ae@gmail.com>
---
Changes in v2:
- Fix the error occured because of pervious fix.
---
drivers/media/usb/gspca/sq905.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/usb/gspca/sq905.c b/drivers/media/usb/gspca/sq905.c
index 97799cfb832e..57206dd2e1a0 100644
--- a/drivers/media/usb/gspca/sq905.c
+++ b/drivers/media/usb/gspca/sq905.c
@@ -157,8 +157,8 @@ static int sq905_ack_frame(struct gspca_dev *gspca_dev)
static int
sq905_read_data(struct gspca_dev *gspca_dev, u8 *data, int size, int need_lock)
{
- int ret;
- int act_len;
+ int ret;
+ int act_len;
gspca_dev->usb_buf[0] = '\0';
if (need_lock)
@@ -180,8 +180,8 @@ sq905_read_data(struct gspca_dev *gspca_dev, u8 *data, int size, int need_lock)
data, size, &act_len, SQ905_DATA_TIMEOUT);
/* successful, it returns 0, otherwise negative */
- if (ret < 0 || act_len != size) {
- pr_err("bulk read fail (%d) len %d/%d\n", ret, act_len, size);
+ if (ret < 0 || act_len != size) {
+ pr_err("bulk read fail (%d) len %d/%d\n", ret, ret < 0 ? -1 : act_len, size);
return -EIO;
}
return 0;
--
2.25.1
next reply other threads:[~2021-03-26 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 21:02 Alaa Emad [this message]
2021-03-26 21:35 ` [PATCH v2] media: sq905.c: fix uninitialized variable Pavel Skripkin
2021-03-27 9:44 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210326210252.129595-1-alaaemadhossney.ae@gmail.com \
--to=alaaemadhossney.ae@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=syzbot+a4e309017a5f3a24c7b3@syzkaller.appspotmail.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox