From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B868C433C1 for ; Sat, 27 Mar 2021 10:20:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E49E761A26 for ; Sat, 27 Mar 2021 10:20:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231192AbhC0KUi (ORCPT ); Sat, 27 Mar 2021 06:20:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230288AbhC0KUh (ORCPT ); Sat, 27 Mar 2021 06:20:37 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13717C0613B1 for ; Sat, 27 Mar 2021 03:20:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=DVjYSyWQdbWu0/nbG+Yl381iPzwCZZyDqilArg4nupU=; b=RWob4ATBhI0omzHwVpSZz+5rJ PvShLfpkCXTTYHLmGnvRsSXA3voEtP4FgpJXYv2PekHAr/Yfe+aeZY19xJ+atsVLlzU/LNYtaFz8x KuR39CKrY6gHyr886ECyy74TXcZBHAadfN/GPWfM6GXo9LqmXtTTrsS1vqrvvRYY18yrqPEBTJL9H png8xT0eNBhQ7ETjTWk8Odqwn1d8n0Qm8tcMKwhsY2AjYkYT00Mk2toronqDhmirBYt+8IKlbJhdH L/c+EfeYhAIjyMuuFMIZWN+GclekFfxR/tzssc1YHqupY71wCFd3Rt8I1aWSCFMBA+PB6/oITQbC0 rPHVGSsBA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:51866) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lQ63B-0006Pg-TG; Sat, 27 Mar 2021 10:20:13 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lQ63A-0007xU-VS; Sat, 27 Mar 2021 10:20:12 +0000 Date: Sat, 27 Mar 2021 10:20:12 +0000 From: Russell King - ARM Linux admin To: Shixin Liu Cc: Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm: 9016/2: Make symbol 'tmp_pmd_table' static Message-ID: <20210327102012.GT1463@shell.armlinux.org.uk> References: <20210327083018.1922539-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210327083018.1922539-1-liushixin2@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Why do you have 9016/2 in the subject line? That's an identifier from the patch system which shouldn't be in the subject line. If you want to refer to something already committed, please do so via the sha1 git hash and quote the first line of the commit description within ("...") in the body of your commit description. Thanks. On Sat, Mar 27, 2021 at 04:30:18PM +0800, Shixin Liu wrote: > Symbol 'tmp_pmd_table' is not used outside of kasan_init.c and only used > when CONFIG_ARM_LPAE enabled. So marks it static and add it into CONFIG_ARM_LPAE. > > Signed-off-by: Shixin Liu > --- > arch/arm/mm/kasan_init.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mm/kasan_init.c b/arch/arm/mm/kasan_init.c > index 9c348042a724..3a06d3b51f97 100644 > --- a/arch/arm/mm/kasan_init.c > +++ b/arch/arm/mm/kasan_init.c > @@ -27,7 +27,9 @@ > > static pgd_t tmp_pgd_table[PTRS_PER_PGD] __initdata __aligned(PGD_SIZE); > > -pmd_t tmp_pmd_table[PTRS_PER_PMD] __page_aligned_bss; > +#ifdef CONFIG_ARM_LPAE > +static pmd_t tmp_pmd_table[PTRS_PER_PMD] __page_aligned_bss; > +#endif > > static __init void *kasan_alloc_block(size_t size) > { > -- > 2.25.1 > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!