Re: [PATCH v1 3/8] software node: Show properties and their values in sysfs

Greg Kroah-Hartman
2021-03-28T13:03:04Z

On Sun, Mar 28, 2021 at 03:56:26PM +0300, Andy Shevchenko wrote:
> On Sun, Mar 28, 2021 at 9:47 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Sun, Mar 28, 2021 at 12:20:07AM +0200, Andy Shevchenko wrote:
> > > It's very convenient to see what properties and their values
> > > are currently being assigned in the registered software nodes.
> > >
> > > Show properties and their values in sysfs.
>
> ...
>
> > > + for (i = 0; i < prop->length / sizeof(u8); i++)
> > > + len += sysfs_emit_at(buf, len, "%u,", ((u8 *)pointer)[i]);
> >
> > No, sysfs is "one value per file", and that is not what you are showing
> > here at all :(
>
> It is following: it's a "one value" for property in question,
>
> As we may read in [1]: "...so it is socially acceptable to express an
> array of values of the same type."
>
> And here is exactly the case: *values of the same type*.

So what is it going to look like exactly? And what tool is going to be
there to parse this mess? Who is going to to use it?

Arrays of data are not "one value".

thanks,

greg k-h