From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ED50C433C1 for ; Sun, 28 Mar 2021 14:24:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6C8261969 for ; Sun, 28 Mar 2021 14:24:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231150AbhC1OYF (ORCPT ); Sun, 28 Mar 2021 10:24:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229499AbhC1OXy (ORCPT ); Sun, 28 Mar 2021 10:23:54 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C79E4C061756 for ; Sun, 28 Mar 2021 07:23:53 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id c8so10235876wrq.11 for ; Sun, 28 Mar 2021 07:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DCuTEjDe/5W2+5Tt64rnHPWnGwo6A54d3KDraPgBqbo=; b=Xg0f16XVCtH4FSffGtc+oVvfY/RQTzT1CUiia4OuCqkzn/ybf7NjtzE6y4zfO2XWfi 05721sPv1S9YMeyet/sLlDflKVsz2BbW1URknSUCkqPlUBgOT0+Qdn3qpc1E3y/SjVXS yXSrqduDDAsv4mW/Mnoaab5m+nw1xLP+Cboe6Nh/j4J1rXN9a75DVZwvhCNGal6I5pE9 Q1ak8zFI/nUVANh8JhYuagzyB4SfuTEaTQWTcD7h0hSbZOyTdznsOjtZVjjFrxRZJSKi 7WvTLrhlp+XSuGvO1GoURGHYG/hk1zx8r1Oy7bUXcYTZsUN/imZ9nZXZgAmHovx6QqWC lzqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DCuTEjDe/5W2+5Tt64rnHPWnGwo6A54d3KDraPgBqbo=; b=Vgx765ZbZVEQyIfmUZV+mmdqgCt+YLyifSfkPCw5Op/JJp/kOi5PmODa/Pw0fntmcb XO19HnyrcvRGde+OBXqaeV5Z+/yMw8d9PReo34YAz/5hVggVpZaTPEgSBtxrRvQ7Fl+X 66lkzrznK9pV6s9BqKjxTPOZEt0sGPpw/0sR0sOf6pexMJGKp5tUaTq+tjN1w9o+hz3J gWk5EIYJRB4hRBIg5TPwEw6oKg0BJVIbZq2KF6nHyhg9HpyqMawAclM9tThd2VObknz2 bPurDAMED1RhlHO3cHw33pmIuCMnfUMV+qbpZyPOfF5Z5VxttQf+sg9z7W7tLT/Qpz+g YRIw== X-Gm-Message-State: AOAM5325Icy3Z0Pjzq9/RSwsf97IYym9KHUwev2KZ8QUbMylesYnH1vs mKEVyZ+nycH3iXeKz2QS32RVmOUZRJ320A== X-Google-Smtp-Source: ABdhPJwfVuGHbgAxAM1l4vYOBmHnvNDuO9vuw74HOi837D+KQU2q+eVP/A0K8g4QzL5JpC5QAwO67A== X-Received: by 2002:a5d:6304:: with SMTP id i4mr23996904wru.155.1616941432347; Sun, 28 Mar 2021 07:23:52 -0700 (PDT) Received: from agape.jhs ([151.47.29.17]) by smtp.gmail.com with ESMTPSA id m14sm19653524wmi.27.2021.03.28.07.23.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Mar 2021 07:23:51 -0700 (PDT) Date: Sun, 28 Mar 2021 16:23:48 +0200 From: Fabio Aiuto To: Greg KH Cc: dan.carpenter@oracle.com, david.laight@aculab.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 19/20] staging: rtl8723bs: include macro in a do - while loop in core/rtw_security.c Message-ID: <20210328142347.GA1450@agape.jhs> References: <0f176b08b7a49d6649ff9d5468bd912e58c1db06.1616854134.git.fabioaiuto83@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 28, 2021 at 02:10:03PM +0200, Greg KH wrote: > On Sat, Mar 27, 2021 at 03:24:18PM +0100, Fabio Aiuto wrote: > > fix the following checkpatch warning: > > > > ERROR: Macros with multiple statements should be enclosed > > in a do - while loop > > 2014: FILE: drivers/staging/rtl8723bs/core/rtw_security.c:2014: > > +#define ROUND(i, d, s) \ > > > > Signed-off-by: Fabio Aiuto > > --- > > drivers/staging/rtl8723bs/core/rtw_security.c | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c > > index 0ddd7667a986..8a447e149438 100644 > > --- a/drivers/staging/rtl8723bs/core/rtw_security.c > > +++ b/drivers/staging/rtl8723bs/core/rtw_security.c > > @@ -2012,10 +2012,12 @@ static void rijndaelEncrypt(u32 rk[/*44*/], u8 pt[16], u8 ct[16]) > > s3 = GETU32(pt + 12) ^ rk[3]; > > > > #define ROUND(i, d, s) \ > > -d##0 = TE0(s##0) ^ TE1(s##1) ^ TE2(s##2) ^ TE3(s##3) ^ rk[4 * i]; \ > > -d##1 = TE0(s##1) ^ TE1(s##2) ^ TE2(s##3) ^ TE3(s##0) ^ rk[4 * i + 1]; \ > > -d##2 = TE0(s##2) ^ TE1(s##3) ^ TE2(s##0) ^ TE3(s##1) ^ rk[4 * i + 2]; \ > > -d##3 = TE0(s##3) ^ TE1(s##0) ^ TE2(s##1) ^ TE3(s##2) ^ rk[4 * i + 3] > > + do { \ > > + d##0 = TE0(s##0) ^ TE1(s##1) ^ TE2(s##2) ^ TE3(s##3) ^ rk[4 * i]; \ > > + d##1 = TE0(s##1) ^ TE1(s##2) ^ TE2(s##3) ^ TE3(s##0) ^ rk[4 * i + 1]; \ > > + d##2 = TE0(s##2) ^ TE1(s##3) ^ TE2(s##0) ^ TE3(s##1) ^ rk[4 * i + 2]; \ > > + d##3 = TE0(s##3) ^ TE1(s##0) ^ TE2(s##1) ^ TE3(s##2) ^ rk[4 * i + 3]; \ > > + } while (0) > > Why is this code not using the in-kernel crypto code instead? I'll take > this but that should be something that is done to this code > eventually... > > thanks, > > greg k-h ok, I will indagate fo the fix. thank you, fabio