Re: [PATCH] net/ncsi: Avoid channel_monitor hrtimer deadlock

patchwork-bot+netdevbpf
2021-03-30T20:21:04Z

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 29 Mar 2021 10:20:39 -0500 you wrote:
> From: Milton Miller <miltonm@us.ibm.com>
>
> Calling ncsi_stop_channel_monitor from channel_monitor is a guaranteed
> deadlock on SMP because stop calls del_timer_sync on the timer that
> inoked channel_monitor as its timer function.
>
> Recognise the inherent race of marking the monitor disabled before
> deleting the timer by just returning if enable was cleared. After
> a timeout (the default case -- reset to START when response received)
> just mark the monitor.enabled false.
>
> [...]

Here is the summary with links:
- net/ncsi: Avoid channel_monitor hrtimer deadlock
https://git.kernel.org/netdev/net/c/03cb4d05b4ea

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.