* [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature
@ 2021-03-25 4:06 Jisheng Zhang
2021-03-30 6:53 ` Heiko Thiery
2021-03-30 8:26 ` Jens Wiklander
0 siblings, 2 replies; 7+ messages in thread
From: Jisheng Zhang @ 2021-03-25 4:06 UTC (permalink / raw)
To: Jens Wiklander, Steven Rostedt, Guenter Roeck; +Cc: op-tee, linux-kernel
If build kernel without "O=dir", below error will be seen:
In file included from drivers/tee/optee/optee_trace.h:67,
from drivers/tee/optee/call.c:18:
./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory
95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
| ^
compilation terminated.
Fix it by adding below line to Makefile:
CFLAGS_call.o := -I$(src)
Tested with and without "O=dir", both can build successfully.
Reported-by: Guenter Roeck <linux@roeck-us.net>
Suggested-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
---
drivers/tee/optee/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/tee/optee/Makefile b/drivers/tee/optee/Makefile
index 56263ae3b1d7..3aa33ea9e6a6 100644
--- a/drivers/tee/optee/Makefile
+++ b/drivers/tee/optee/Makefile
@@ -6,3 +6,6 @@ optee-objs += rpc.o
optee-objs += supp.o
optee-objs += shm_pool.o
optee-objs += device.o
+
+# for tracing framework to find optee_trace.h
+CFLAGS_call.o := -I$(src)
--
2.31.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature
2021-03-25 4:06 [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature Jisheng Zhang
@ 2021-03-30 6:53 ` Heiko Thiery
2021-03-30 8:26 ` Jens Wiklander
1 sibling, 0 replies; 7+ messages in thread
From: Heiko Thiery @ 2021-03-30 6:53 UTC (permalink / raw)
To: jisheng.zhang
Cc: jens.wiklander, linux-kernel, linux, op-tee, rostedt,
Heiko Thiery
> If build kernel without "O=dir", below error will be seen:
>
> In file included from drivers/tee/optee/optee_trace.h:67,
> from drivers/tee/optee/call.c:18:
> ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory
> 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> | ^
> compilation terminated.
>
> Fix it by adding below line to Makefile:
> CFLAGS_call.o := -I$(src)
>
> Tested with and without "O=dir", both can build successfully.
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Fixes: 0101947dbcc3 ("tee: optee: add invoke_fn tracepoints")
Tested-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
> drivers/tee/optee/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tee/optee/Makefile b/drivers/tee/optee/Makefile
> index 56263ae3b1d7..3aa33ea9e6a6 100644
> --- a/drivers/tee/optee/Makefile
> +++ b/drivers/tee/optee/Makefile
> @@ -6,3 +6,6 @@ optee-objs += rpc.o
> optee-objs += supp.o
> optee-objs += shm_pool.o
> optee-objs += device.o
> +
> +# for tracing framework to find optee_trace.h
> +CFLAGS_call.o := -I$(src)
> --
> 2.31.0
>
Thank you.
--
Heiko
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature
2021-03-25 4:06 [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature Jisheng Zhang
2021-03-30 6:53 ` Heiko Thiery
@ 2021-03-30 8:26 ` Jens Wiklander
2021-04-06 10:38 ` Heiko Thiery
1 sibling, 1 reply; 7+ messages in thread
From: Jens Wiklander @ 2021-03-30 8:26 UTC (permalink / raw)
To: Jisheng Zhang
Cc: Steven Rostedt, Guenter Roeck, Heiko Thiery, op-tee, linux-kernel
On Thu, Mar 25, 2021 at 12:06:01PM +0800, Jisheng Zhang wrote:
> If build kernel without "O=dir", below error will be seen:
>
> In file included from drivers/tee/optee/optee_trace.h:67,
> from drivers/tee/optee/call.c:18:
> ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory
> 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> | ^
> compilation terminated.
>
> Fix it by adding below line to Makefile:
> CFLAGS_call.o := -I$(src)
>
> Tested with and without "O=dir", both can build successfully.
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
I've picked up this.
Thanks,
Jens
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature
2021-03-30 8:26 ` Jens Wiklander
@ 2021-04-06 10:38 ` Heiko Thiery
2021-04-06 12:30 ` Jens Wiklander
0 siblings, 1 reply; 7+ messages in thread
From: Heiko Thiery @ 2021-04-06 10:38 UTC (permalink / raw)
To: Jens Wiklander
Cc: Jisheng Zhang, Steven Rostedt, Guenter Roeck, op-tee,
linux-kernel
Hi Jens,
Am Di., 30. März 2021 um 10:26 Uhr schrieb Jens Wiklander
<jens.wiklander@linaro.org>:
>
> On Thu, Mar 25, 2021 at 12:06:01PM +0800, Jisheng Zhang wrote:
> > If build kernel without "O=dir", below error will be seen:
> >
> > In file included from drivers/tee/optee/optee_trace.h:67,
> > from drivers/tee/optee/call.c:18:
> > ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory
> > 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> > | ^
> > compilation terminated.
> >
> > Fix it by adding below line to Makefile:
> > CFLAGS_call.o := -I$(src)
> >
> > Tested with and without "O=dir", both can build successfully.
> >
> > Reported-by: Guenter Roeck <linux@roeck-us.net>
> > Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> > Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
>
> I've picked up this.
For what tree did you pick this? I still see this build failure on the
latest next tree (next-20210401).
>
> Thanks,
> Jens
Thank you,
Heiko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature
2021-04-06 10:38 ` Heiko Thiery
@ 2021-04-06 12:30 ` Jens Wiklander
2021-04-06 14:20 ` Heiko Thiery
0 siblings, 1 reply; 7+ messages in thread
From: Jens Wiklander @ 2021-04-06 12:30 UTC (permalink / raw)
To: Heiko Thiery
Cc: Jisheng Zhang, Steven Rostedt, Guenter Roeck,
OP-TEE TrustedFirmware, Linux Kernel Mailing List, Arnd Bergmann
Hi Heiko,
[+Arnd]
On Tue, Apr 6, 2021 at 12:38 PM Heiko Thiery <heiko.thiery@gmail.com> wrote:
>
> Hi Jens,
>
> Am Di., 30. März 2021 um 10:26 Uhr schrieb Jens Wiklander
> <jens.wiklander@linaro.org>:
> >
> > On Thu, Mar 25, 2021 at 12:06:01PM +0800, Jisheng Zhang wrote:
> > > If build kernel without "O=dir", below error will be seen:
> > >
> > > In file included from drivers/tee/optee/optee_trace.h:67,
> > > from drivers/tee/optee/call.c:18:
> > > ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory
> > > 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> > > | ^
> > > compilation terminated.
> > >
> > > Fix it by adding below line to Makefile:
> > > CFLAGS_call.o := -I$(src)
> > >
> > > Tested with and without "O=dir", both can build successfully.
> > >
> > > Reported-by: Guenter Roeck <linux@roeck-us.net>
> > > Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> > > Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> >
> > I've picked up this.
>
> For what tree did you pick this? I still see this build failure on the
> latest next tree (next-20210401).
The next tree hasn't been updated since 1th of April so it's not
unexpected. The fix is supposed to be on its way to
https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=arm/drivers
, I can't see it there yet though.
Cheers,
Jens
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature
2021-04-06 12:30 ` Jens Wiklander
@ 2021-04-06 14:20 ` Heiko Thiery
0 siblings, 0 replies; 7+ messages in thread
From: Heiko Thiery @ 2021-04-06 14:20 UTC (permalink / raw)
To: Jens Wiklander
Cc: Jisheng Zhang, Steven Rostedt, Guenter Roeck,
OP-TEE TrustedFirmware, Linux Kernel Mailing List, Arnd Bergmann
Hi Jens,
Am Di., 6. Apr. 2021 um 14:30 Uhr schrieb Jens Wiklander
<jens.wiklander@linaro.org>:
>
> Hi Heiko,
>
> [+Arnd]
>
> On Tue, Apr 6, 2021 at 12:38 PM Heiko Thiery <heiko.thiery@gmail.com> wrote:
> >
> > Hi Jens,
> >
> > Am Di., 30. März 2021 um 10:26 Uhr schrieb Jens Wiklander
> > <jens.wiklander@linaro.org>:
> > >
> > > On Thu, Mar 25, 2021 at 12:06:01PM +0800, Jisheng Zhang wrote:
> > > > If build kernel without "O=dir", below error will be seen:
> > > >
> > > > In file included from drivers/tee/optee/optee_trace.h:67,
> > > > from drivers/tee/optee/call.c:18:
> > > > ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory
> > > > 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> > > > | ^
> > > > compilation terminated.
> > > >
> > > > Fix it by adding below line to Makefile:
> > > > CFLAGS_call.o := -I$(src)
> > > >
> > > > Tested with and without "O=dir", both can build successfully.
> > > >
> > > > Reported-by: Guenter Roeck <linux@roeck-us.net>
> > > > Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> > > > Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> > >
> > > I've picked up this.
> >
> > For what tree did you pick this? I still see this build failure on the
> > latest next tree (next-20210401).
>
> The next tree hasn't been updated since 1th of April so it's not
> unexpected. The fix is supposed to be on its way to
> https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=arm/drivers
> , I can't see it there yet though.
Ah I see. Now it has been landed in the actual next tree.
Thank you,
Heiko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature
@ 2021-03-25 4:57 Guenter Roeck
0 siblings, 0 replies; 7+ messages in thread
From: Guenter Roeck @ 2021-03-25 4:57 UTC (permalink / raw)
To: Jisheng Zhang; +Cc: Jens Wiklander, Steven Rostedt, op-tee, linux-kernel
On Thu, Mar 25, 2021 at 12:06:01PM +0800, Jisheng Zhang wrote:
> If build kernel without "O=dir", below error will be seen:
>
> In file included from drivers/tee/optee/optee_trace.h:67,
> from drivers/tee/optee/call.c:18:
> ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory
> 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> | ^
> compilation terminated.
>
> Fix it by adding below line to Makefile:
> CFLAGS_call.o := -I$(src)
>
> Tested with and without "O=dir", both can build successfully.
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/tee/optee/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tee/optee/Makefile b/drivers/tee/optee/Makefile
> index 56263ae3b1d7..3aa33ea9e6a6 100644
> --- a/drivers/tee/optee/Makefile
> +++ b/drivers/tee/optee/Makefile
> @@ -6,3 +6,6 @@ optee-objs += rpc.o
> optee-objs += supp.o
> optee-objs += shm_pool.o
> optee-objs += device.o
> +
> +# for tracing framework to find optee_trace.h
> +CFLAGS_call.o := -I$(src)
> --
> 2.31.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-04-06 14:21 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-25 4:06 [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature Jisheng Zhang
2021-03-30 6:53 ` Heiko Thiery
2021-03-30 8:26 ` Jens Wiklander
2021-04-06 10:38 ` Heiko Thiery
2021-04-06 12:30 ` Jens Wiklander
2021-04-06 14:20 ` Heiko Thiery
-- strict thread matches above, loose matches on Subject: below --
2021-03-25 4:57 Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox