From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D771C433E0 for ; Tue, 30 Mar 2021 16:54:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F41FC619CD for ; Tue, 30 Mar 2021 16:54:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232335AbhC3Qxy (ORCPT ); Tue, 30 Mar 2021 12:53:54 -0400 Received: from verein.lst.de ([213.95.11.211]:59758 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232246AbhC3Qxc (ORCPT ); Tue, 30 Mar 2021 12:53:32 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 8C3BC68B02; Tue, 30 Mar 2021 18:53:30 +0200 (CEST) Date: Tue, 30 Mar 2021 18:53:30 +0200 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] block: shutdown blktrace in case of fatal signal pending Message-ID: <20210330165330.GA13829@lst.de> References: <20210323081440.81343-1-ming.lei@redhat.com> <20210323081440.81343-2-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210323081440.81343-2-ming.lei@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 23, 2021 at 04:14:39PM +0800, Ming Lei wrote: > blktrace may allocate lots of memory, if the process is terminated > by user or OOM, we need to provide one chance to remove the trace > buffer, otherwise memory leak may be caused. > > Fix the issue by shutdown blktrace in case of task exiting in > blkdev_close(). > > Signed-off-by: Ming Lei This just seems weird. blktrace has no relationship to open block device instances.