From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2CDBC433C1 for ; Tue, 30 Mar 2021 09:21:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE6A06024A for ; Tue, 30 Mar 2021 09:21:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231593AbhC3JVN (ORCPT ); Tue, 30 Mar 2021 05:21:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:54578 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231624AbhC3JVL (ORCPT ); Tue, 30 Mar 2021 05:21:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 451A36024A; Tue, 30 Mar 2021 09:21:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617096070; bh=4R/2RqA5Y/KuA/x2pUUPA6JHkojRGW/5pd8HtMfeQY4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Cy2uNLDJC2WSJyN5Jhbvad2rPcKnpg0I9jfbw3PLlljdmZpPLSILGPwooa2EXBj03 WjRWby+w3gfdlmyTBktRFaetLTiIVYiLPHBJNAPsUbGYQUUDksWyzIJSCKKOfA+f99 9D4Y66szN9uxWbtgnVlabzIPI8gUvJn2h8/nC5Z5fiHRvsuYtaq3GbfZVWJWsvwOHK HcaLhHA4c7LojzqaOHBAPBdd5fy9U/6d1o00/zSb7dMlii9SA70oytfZQQcbWUY2Ft 8wPZu/UzuVGTIhOlT04n60C7ewEzzsHUyGatHRedppAAzldHVdEFXzBEblVS0pS5wd uEoOlxcERpuQQ== Date: Tue, 30 Mar 2021 18:21:05 +0900 From: Masami Hiramatsu To: Jisheng Zhang Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] riscv: add do_page_fault and do_trap_break into the kprobes blacklist Message-Id: <20210330182105.47a24038fc014ba0dcd917a4@kernel.org> In-Reply-To: <20210330021226.2fc7b2ec@xhacker> References: <20210330021226.2fc7b2ec@xhacker> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Mar 2021 02:12:26 +0800 Jisheng Zhang wrote: > From: Jisheng Zhang > > These two functions are used to implement the kprobes feature so they > can't be kprobed. > Looks good to me. Reviewed-by: Masami Hiramatsu Thanks, > Fixes: c22b0bcb1dd0 ("riscv: Add kprobes supported") > Signed-off-by: Jisheng Zhang > --- > arch/riscv/kernel/traps.c | 1 + > arch/riscv/mm/fault.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c > index 0879b5df11b9..1357abf79570 100644 > --- a/arch/riscv/kernel/traps.c > +++ b/arch/riscv/kernel/traps.c > @@ -178,6 +178,7 @@ asmlinkage __visible void do_trap_break(struct pt_regs *regs) > else > die(regs, "Kernel BUG"); > } > +NOKPROBE_SYMBOL(do_trap_break); > > #ifdef CONFIG_GENERIC_BUG > int is_valid_bugaddr(unsigned long pc) > diff --git a/arch/riscv/mm/fault.c b/arch/riscv/mm/fault.c > index 8f17519208c7..c5dbd55cbf7c 100644 > --- a/arch/riscv/mm/fault.c > +++ b/arch/riscv/mm/fault.c > @@ -328,3 +328,4 @@ asmlinkage void do_page_fault(struct pt_regs *regs) > } > return; > } > +NOKPROBE_SYMBOL(do_page_fault); > -- > 2.31.0 > > -- Masami Hiramatsu