From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC1E5C433DB for ; Tue, 30 Mar 2021 09:23:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B617C6024A for ; Tue, 30 Mar 2021 09:23:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231702AbhC3JWu (ORCPT ); Tue, 30 Mar 2021 05:22:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:54740 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231653AbhC3JWR (ORCPT ); Tue, 30 Mar 2021 05:22:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DF7236024A; Tue, 30 Mar 2021 09:22:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617096137; bh=uDfFMsetRa84Y+TVUQV9pEFfOKCsf9PIepiuOFlvhUQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ItwDsKq5s0Tqu1E4H9sjbwyjediMnllkizLTx8/OluZVtW+Sm7d9XzHOe3dZ/upKK wW9JsfyqBD9R3oCMJbNrXHjINjeXH8Z2xu9Kw1QjJltIChjlCGZDu1r026hTmYDjI+ EILJTAqKPOsRPZK+yXImN3nLz4aiXT1Zyzg+Usu16nwjiVbFuP7g0Um38UsMs5OBsV nt2kH+eoGaM5HY0lUgvP/t7oSmGwXC60yZMYry7MZmkdPfm7zkqHH0mTJuXoIMtbvT 4y8xKB3K4iG9P1H+L+h0wLnhaqgsVUQ7SnmE9NhcArki9AlIsUD+ogyPZ3p/s2eRLH UAi0ymSJGXqZA== Date: Tue, 30 Mar 2021 18:21:56 +0900 From: Masami Hiramatsu To: Jisheng Zhang Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Jonathan Corbet , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH] samples/kprobes: Add riscv support Message-Id: <20210330182156.d2cd8680e99cfe1a75068732@kernel.org> In-Reply-To: <20210330020416.129505e6@xhacker> References: <20210330020416.129505e6@xhacker> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Mar 2021 02:04:16 +0800 Jisheng Zhang wrote: > From: Jisheng Zhang > > Add riscv specific info dump in both handler_pre() and handler_post(). > Looks good to me. Acked-by: Masami Hiramatsu Thanks! > Signed-off-by: Jisheng Zhang > --- > samples/kprobes/kprobe_example.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c > index 331dcf151532..c495664c0a9b 100644 > --- a/samples/kprobes/kprobe_example.c > +++ b/samples/kprobes/kprobe_example.c > @@ -47,6 +47,10 @@ static int __kprobes handler_pre(struct kprobe *p, struct pt_regs *regs) > pr_info("<%s> pre_handler: p->addr = 0x%p, pc = 0x%lx, cpsr = 0x%lx\n", > p->symbol_name, p->addr, (long)regs->ARM_pc, (long)regs->ARM_cpsr); > #endif > +#ifdef CONFIG_RISCV > + pr_info("<%s> pre_handler: p->addr = 0x%p, pc = 0x%lx, status = 0x%lx\n", > + p->symbol_name, p->addr, regs->epc, regs->status); > +#endif > #ifdef CONFIG_S390 > pr_info("<%s> pre_handler: p->addr, 0x%p, ip = 0x%lx, flags = 0x%lx\n", > p->symbol_name, p->addr, regs->psw.addr, regs->flags); > @@ -80,6 +84,10 @@ static void __kprobes handler_post(struct kprobe *p, struct pt_regs *regs, > pr_info("<%s> post_handler: p->addr = 0x%p, cpsr = 0x%lx\n", > p->symbol_name, p->addr, (long)regs->ARM_cpsr); > #endif > +#ifdef CONFIG_RISCV > + pr_info("<%s> post_handler: p->addr = 0x%p, status = 0x%lx\n", > + p->symbol_name, p->addr, regs->status); > +#endif > #ifdef CONFIG_S390 > pr_info("<%s> pre_handler: p->addr, 0x%p, flags = 0x%lx\n", > p->symbol_name, p->addr, regs->flags); > -- > 2.31.0 > > -- Masami Hiramatsu