From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] MIPS: uaccess: Remove get_fs/set_fs call sites
Date: Tue, 30 Mar 2021 22:02:22 +0200 [thread overview]
Message-ID: <20210330200222.GB18146@alpha.franken.de> (raw)
In-Reply-To: <20210330174943.GB15145@lst.de>
On Tue, Mar 30, 2021 at 07:49:43PM +0200, Christoph Hellwig wrote:
> On Tue, Mar 30, 2021 at 07:26:59PM +0200, Thomas Bogendoerfer wrote:
> > +#define __get_data(x, ptr, u) \
> > + (((u) == true) ? __get_udata((x), (ptr), sizeof(*(ptr))) : \
> > + __get_kdata((x), (ptr), sizeof(*(ptr))))
> > +
>
> I'm a little worried about exposing this in uaccess.h. Can you
> have local helpers insted, preferably strongly typed for their
> specific use cases?
sure, no problem.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2021-03-30 20:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 17:26 [PATCH 0/3] MIPS: Remove get_fs/set_fs Thomas Bogendoerfer
2021-03-30 17:26 ` [PATCH 1/3] MIPS: uaccess: Added __get/__put_kernel_nofault Thomas Bogendoerfer
2021-03-30 17:48 ` Christoph Hellwig
2021-03-30 20:02 ` Thomas Bogendoerfer
2021-03-30 17:26 ` [PATCH 2/3] MIPS: uaccess: Remove get_fs/set_fs call sites Thomas Bogendoerfer
2021-03-30 17:49 ` Christoph Hellwig
2021-03-30 20:02 ` Thomas Bogendoerfer [this message]
2021-03-30 22:10 ` David Laight
2021-03-30 17:27 ` [PATCH 3/3] MIPS: Remove get_fs/set_fs Thomas Bogendoerfer
2021-03-30 17:54 ` Christoph Hellwig
2021-03-31 11:41 ` Thomas Bogendoerfer
2021-03-31 1:38 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330200222.GB18146@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox