Re: [PATCH v3 5/6] usb: Iterator for ports

kernel test robot
2021-03-31T14:28:38Z

[-- Attachment #1: Type: text/plain, Size: 3220 bytes --]

Hi Heikki,

I love your patch! Yet something to improve:

[auto build test ERROR on peter.chen-usb/for-usb-next]
[also build test ERROR on linus/master v5.12-rc5 next-20210331]
[cannot apply to usb/usb-testing balbi-usb/testing/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Heikki-Krogerus/usb-Linking-ports-to-their-Type-C-connectors/20210331-190638
base: https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git for-usb-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/067cb7efe925811fd52b7b9550578f88a20d2226
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Heikki-Krogerus/usb-Linking-ports-to-their-Type-C-connectors/20210331-190638
git checkout 067cb7efe925811fd52b7b9550578f88a20d2226
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/usb/core/usb.c:439:5: error: redefinition of 'usb_for_each_port'
439 | int usb_for_each_port(void *data, int (*fn)(struct device *, void *))
| ^~~~~~~~~~~~~~~~~
In file included from drivers/usb/core/usb.c:35:
include/linux/usb.h:884:19: note: previous definition of 'usb_for_each_port' was here
884 | static inline int usb_for_each_port(void *data, int (*fn)(struct device *, void *))
| ^~~~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
Selected by
- SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
- SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC

vim +/usb_for_each_port +439 drivers/usb/core/usb.c

429
430 /**
431 * usb_for_each_port - interate over all USB ports in the system
432 * @data: data pointer that will be handed to the callback function
433 * @fn: callback function to be called for each USB port
434 *
435 * Iterate over all USB ports and call @fn for each, passing it @data. If it
436 * returns anything other than 0, we break the iteration prematurely and return
437 * that value.
438 */
> 439 int usb_for_each_port(void *data, int (*fn)(struct device *, void *))
440 {
441 struct each_hub_arg arg = {data, fn};
442
443 return usb_for_each_dev(&arg, __each_hub);
444 }
445 EXPORT_SYMBOL_GPL(usb_for_each_port);
446

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 54175 bytes --]