From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71367C433ED for ; Thu, 1 Apr 2021 10:32:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C6A161056 for ; Thu, 1 Apr 2021 10:32:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234014AbhDAKbt (ORCPT ); Thu, 1 Apr 2021 06:31:49 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:2756 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233834AbhDAKbj (ORCPT ); Thu, 1 Apr 2021 06:31:39 -0400 Received: from fraeml702-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4F9znv0bmMz685Dg; Thu, 1 Apr 2021 18:24:51 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml702-chm.china.huawei.com (10.206.15.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2106.2; Thu, 1 Apr 2021 12:31:37 +0200 Received: from localhost (10.47.80.95) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 1 Apr 2021 11:31:36 +0100 Date: Thu, 1 Apr 2021 11:30:15 +0100 From: Jonathan Cameron To: Andy Shevchenko CC: Mugilraj Dhavachelvan , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Ray Jui , Scott Branden , bcm-kernel-feedback-list , linux-iio , linux-arm Mailing List , Linux Kernel Mailing List Subject: Re: [PATCH] iio: adc: bcm_iproc_adc: Use %s and __func__ Message-ID: <20210401113015.00006b70@Huawei.com> In-Reply-To: References: <20210401062517.28832-1-dmugil2000@gmail.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.80.95] X-ClientProxiedBy: lhreml715-chm.china.huawei.com (10.201.108.66) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Apr 2021 12:24:50 +0300 Andy Shevchenko wrote: > On Thu, Apr 1, 2021 at 9:27 AM Mugilraj Dhavachelvan > wrote: > > > > Change function's name to %s and __func__ to fix checkpatch.pl errors. > > No, just drop the __func__ completely. First of all, we have a device > name, and uniqueness of the messages in the driver should guarantee > easy findings. Second, specific to _dbg() variants, with enabled > Dynamic Debug it can be chosen at run time! > > I recommend going through all drivers and drop __func__ near to > dev_dbg() and pr_debug(). > Agreed. Though beware that some maintainers will count this as noise and get grumpy. I'm fine with such patches for IIO. Jonathan