From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00757C433B4 for ; Fri, 2 Apr 2021 12:40:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C994061165 for ; Fri, 2 Apr 2021 12:40:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235465AbhDBMkx (ORCPT ); Fri, 2 Apr 2021 08:40:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234161AbhDBMkw (ORCPT ); Fri, 2 Apr 2021 08:40:52 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AFC8C0613E6 for ; Fri, 2 Apr 2021 05:40:51 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id v11so4633452wro.7 for ; Fri, 02 Apr 2021 05:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BNYUKZHrMhvTPOFQ1droPRgbVu7CLrkiY6RX4hkaSxA=; b=CinOx2ahgmQnkhPg+emJ4c/OIpkUqWOEydyPkQdaHZpOZEL65VFQkeDeF62HQQ9PJb D6LvQeUI2Ae66hMZeBJMxGRKUuP/FaQctBCXvS9e3Rfwhsn74Ixpp1cqiXnbCLZOT5gT +N1AFKV8Ajm+JkS/RYARcwy/fbnUf6zkzXt+kF60+UTIdAdrT9I1pEFGru4IREQjgd7c oQcaPAdDz6Dp5jpvApK/BB1Wf709gn8/iVJi6QwFIJM3KvJ5fhu0+wkmHP9dbCnwNE1Q KtDrOxYUwlrzLtO9d7pLasOKBqwEHzcA/oQR4m7qGFrEKS5H8TyscuC+BSWG34C65IOC XkUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BNYUKZHrMhvTPOFQ1droPRgbVu7CLrkiY6RX4hkaSxA=; b=Iusx605CthidTnDVJCbJ5lmtTeGeq9yTCez8+v1Rrw35sVjnbaxywczP8zupRYD4Jn GF8FRu9VGcg3AtqPGEXdgoZd3bvBtS34zVT+m+wopl2GNojkE+/noocBixH++oWm60cP iMx8ShgApSn272yK5KH9o5b4sacHpDwQ6WSf6TexkkOk2u+lKOWpQ0K03LxG4BS04HUq Wjv6X1qWFYS7aSZ0dPCLCc6a2AGuSuaauCH2t72d1y7ud2I1DplVcyUZZtFUNGP679BP mh4ZaOUE28okF598C7TFOpAdXteVbDJmM9hGu226ZdZuQbVsPZHlXwnGf9bjIIdClHkQ mtPA== X-Gm-Message-State: AOAM533St88DRSm8tqZpDQUsSj27EbkbrE94Ycm8RRShHn3nii6LqIZj 5GX16t4NccaauhxWtVicrJyWeN86YYXl7A== X-Google-Smtp-Source: ABdhPJyXhFmNwuFZ6RiAxeiFyk6B8myjdOkmCJxAqUQpfnwijxF6oZR1CxQgtGANwyulpgEgDum4lQ== X-Received: by 2002:adf:ea0c:: with SMTP id q12mr2517845wrm.2.1617367249808; Fri, 02 Apr 2021 05:40:49 -0700 (PDT) Received: from agape.jhs ([5.171.80.213]) by smtp.gmail.com with ESMTPSA id k11sm12342998wmj.1.2021.04.02.05.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Apr 2021 05:40:49 -0700 (PDT) Date: Fri, 2 Apr 2021 14:40:46 +0200 From: Fabio Aiuto To: Dan Carpenter Cc: gregkh@linuxfoundation.org, joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c Message-ID: <20210402124045.GA1420@agape.jhs> References: <72ab5222629f912ca2dbe825d194108992d321e7.1617356821.git.fabioaiuto83@gmail.com> <20210402115626.GV2088@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210402115626.GV2088@kadam> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 02, 2021 at 02:56:26PM +0300, Dan Carpenter wrote: > On Fri, Apr 02, 2021 at 12:01:21PM +0200, Fabio Aiuto wrote: > > @@ -568,20 +561,11 @@ static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *p > > if (pattrib->encrypt > 0) > > memcpy(pattrib->dot118021x_UncstKey.skey, psta->dot118021x_UncstKey.skey, 16); > > > > - RT_TRACE(_module_rtl871x_xmit_c_, _drv_info_, > > - ("update_attrib: encrypt =%d securitypriv.sw_encrypt =%d\n", > > - pattrib->encrypt, padapter->securitypriv.sw_encrypt)); > > - > > if (pattrib->encrypt && > > - ((padapter->securitypriv.sw_encrypt == true) || (psecuritypriv->hw_decrypted == false))) { > > + ((padapter->securitypriv.sw_encrypt) || (!psecuritypriv->hw_decrypted))) > > You've done too much clean up here. Just remove the { but leave the > == true/false comparisons. > > If the patch is only changing five lines or code then fixing checkpatch > warnings on the line of code you are changing is fine, but in this case > you're doing a bunch of changes and these sort of cleanups make it hard > to review. > > Ease to spot that the curly brace changed: > - ((padapter->securitypriv.sw_encrypt == true) || (psecuritypriv->hw_decrypted == false))) { > + ((padapter->securitypriv.sw_encrypt == true) || (psecuritypriv->hw_decrypted == false))) > > Hard to spot: > - ((padapter->securitypriv.sw_encrypt == true) || (psecuritypriv->hw_decrypted == false))) { > + ((padapter->securitypriv.sw_encrypt) || (!psecuritypriv->hw_decrypted))) > > regards, > dan carpenter > thank you Dan, it's a good tuning process for me. Shall I resend the whole patchset? Maybe some of them are ok... fabio