From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86719C433B4 for ; Fri, 2 Apr 2021 14:45:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 508C461006 for ; Fri, 2 Apr 2021 14:45:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234459AbhDBOpC (ORCPT ); Fri, 2 Apr 2021 10:45:02 -0400 Received: from verein.lst.de ([213.95.11.211]:43825 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbhDBOo7 (ORCPT ); Fri, 2 Apr 2021 10:44:59 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 2051768BEB; Fri, 2 Apr 2021 16:44:56 +0200 (CEST) Date: Fri, 2 Apr 2021 16:44:55 +0200 From: Christoph Hellwig To: "Song Bao Hua (Barry Song)" Cc: Christoph Hellwig , "tiantao (H)" , "akpm@linux-foundation.org" , "peterz@infradead.org" , "paulmck@kernel.org" , "ast@kernel.org" , "tglx@linutronix.de" , "rostedt@goodmis.org" , "m.szyprowski@samsung.com" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] dma-mapping: make map_benchmark compile into module Message-ID: <20210402144455.GA19264@lst.de> References: <1616552258-22282-1-git-send-email-tiantao6@hisilicon.com> <20210324071305.GB647@lst.de> <6153f9d247214d58b5eb7a76cb1258b3@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6153f9d247214d58b5eb7a76cb1258b3@hisilicon.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 24, 2021 at 07:33:23AM +0000, Song Bao Hua (Barry Song) wrote: > The requirement comes from an colleague who is frequently changing > the map-bench code for some customized test purpose. and he doesn't > want to build kernel image and reboot every time. So I moved the > requirement to Tao Tian. > > Right now, kthread_bind() is exported, kthread_bind_mask() seems > to be a little bit "internal" as you said, maybe a wrapper like > kthread_bind_node() won't be that "internal", comparing to exposing > the cpumask? I really don't think we should be exporting more low-level kthread APIs. Especially as we've been trying to get most users off the kthread API and to workqueues instead.