From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] block: shutdown blktrace in case of fatal signal pending
Date: Fri, 2 Apr 2021 19:27:30 +0200 [thread overview]
Message-ID: <20210402172730.GA22923@lst.de> (raw)
In-Reply-To: <YGO/cpalyGevAJjn@T590>
On Wed, Mar 31, 2021 at 08:16:50AM +0800, Ming Lei wrote:
> On Tue, Mar 30, 2021 at 06:53:30PM +0200, Christoph Hellwig wrote:
> > On Tue, Mar 23, 2021 at 04:14:39PM +0800, Ming Lei wrote:
> > > blktrace may allocate lots of memory, if the process is terminated
> > > by user or OOM, we need to provide one chance to remove the trace
> > > buffer, otherwise memory leak may be caused.
> > >
> > > Fix the issue by shutdown blktrace in case of task exiting in
> > > blkdev_close().
> > >
> > > Signed-off-by: Ming Lei <ming.lei@redhat.com>
> >
> > This just seems weird. blktrace has no relationship to open
> > block device instances.
>
> blktrace still needs to open one blkdev, then send its own ioctl
> commands to block layer. In case of OOM, the allocated memory in
> these ioctl commands won't be released.
>
> Or any other suggestion?
Not much we can do there I think. If we want to autorelease memory
it needs to be an API that ties the memory allocation to an FD.
next prev parent reply other threads:[~2021-04-02 17:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 8:14 [PATCH 0/2] blktrace: fix trace buffer leak and limit trace buffer size Ming Lei
2021-03-23 8:14 ` [PATCH 1/2] block: shutdown blktrace in case of fatal signal pending Ming Lei
2021-03-30 16:53 ` Christoph Hellwig
2021-03-31 0:16 ` Ming Lei
2021-04-02 17:27 ` Christoph Hellwig [this message]
2021-04-03 8:10 ` Ming Lei
2021-04-03 9:04 ` Ming Lei
2021-04-06 6:30 ` Christoph Hellwig
2021-03-23 8:14 ` [PATCH 2/2] blktrace: limit allowed total trace buffer size Ming Lei
2021-03-30 2:57 ` Su Yue
2021-03-30 3:55 ` Ming Lei
2021-03-30 16:57 ` Christoph Hellwig
2021-03-30 2:04 ` [PATCH 0/2] blktrace: fix trace buffer leak and limit " Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210402172730.GA22923@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox