* [PATCH] powerpc/dts: fix not include DTC_FLAGS
@ 2021-04-03 2:04 Youlin Song
2021-04-07 11:27 ` Michael Ellerman
0 siblings, 1 reply; 3+ messages in thread
From: Youlin Song @ 2021-04-03 2:04 UTC (permalink / raw)
To: robh+dt, mpe, benh, paulus
Cc: devicetree, linuxppc-dev, linux-kernel, Youlin Song
I wanted to build the fsl dts in my machine and found that
the dtb have not extra space,so uboot will cause about
FDT_ERR_NOSPACE issue.
Signed-off-by: Youlin Song <syl.loop@gmail.com>
---
arch/powerpc/boot/dts/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/boot/dts/Makefile b/arch/powerpc/boot/dts/Makefile
index fb335d05aae8..c21165c0cd76 100644
--- a/arch/powerpc/boot/dts/Makefile
+++ b/arch/powerpc/boot/dts/Makefile
@@ -2,5 +2,6 @@
subdir-y += fsl
+DTC_FLAGS ?= -p 1024
dtstree := $(srctree)/$(src)
dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts))
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/dts: fix not include DTC_FLAGS
2021-04-03 2:04 [PATCH] powerpc/dts: fix not include DTC_FLAGS Youlin Song
@ 2021-04-07 11:27 ` Michael Ellerman
2021-04-07 19:58 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Michael Ellerman @ 2021-04-07 11:27 UTC (permalink / raw)
To: Youlin Song, robh+dt, benh, paulus
Cc: devicetree, linuxppc-dev, linux-kernel, Youlin Song
Youlin Song <syl.loop@gmail.com> writes:
> I wanted to build the fsl dts in my machine and found that
> the dtb have not extra space,so uboot will cause about
> FDT_ERR_NOSPACE issue.
>
> Signed-off-by: Youlin Song <syl.loop@gmail.com>
> ---
> arch/powerpc/boot/dts/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/boot/dts/Makefile b/arch/powerpc/boot/dts/Makefile
> index fb335d05aae8..c21165c0cd76 100644
> --- a/arch/powerpc/boot/dts/Makefile
> +++ b/arch/powerpc/boot/dts/Makefile
> @@ -2,5 +2,6 @@
>
> subdir-y += fsl
>
> +DTC_FLAGS ?= -p 1024
> dtstree := $(srctree)/$(src)
> dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts))
I guess that was missed in 1acf1cf8638a ("powerpc: build .dtb files in dts directory").
Which I think means the assignment to DTC_FLAGS in
arch/powerpc/boot/Makefile is not needed anymore.
Can you send a v2 removing that assignment and explaining that's what
happened?
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/dts: fix not include DTC_FLAGS
2021-04-07 11:27 ` Michael Ellerman
@ 2021-04-07 19:58 ` Rob Herring
0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-04-07 19:58 UTC (permalink / raw)
To: Michael Ellerman
Cc: Youlin Song, Benjamin Herrenschmidt, Paul Mackerras, devicetree,
linuxppc-dev, linux-kernel@vger.kernel.org
On Wed, Apr 7, 2021 at 6:27 AM Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> Youlin Song <syl.loop@gmail.com> writes:
> > I wanted to build the fsl dts in my machine and found that
> > the dtb have not extra space,so uboot will cause about
> > FDT_ERR_NOSPACE issue.
How do we not have issues with arm and arm64 boards which don't have
padding? Or what took so long to notice on powerpc?
> >
> > Signed-off-by: Youlin Song <syl.loop@gmail.com>
> > ---
> > arch/powerpc/boot/dts/Makefile | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/powerpc/boot/dts/Makefile b/arch/powerpc/boot/dts/Makefile
> > index fb335d05aae8..c21165c0cd76 100644
> > --- a/arch/powerpc/boot/dts/Makefile
> > +++ b/arch/powerpc/boot/dts/Makefile
> > @@ -2,5 +2,6 @@
> >
> > subdir-y += fsl
> >
> > +DTC_FLAGS ?= -p 1024
> > dtstree := $(srctree)/$(src)
> > dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts))
>
> I guess that was missed in 1acf1cf8638a ("powerpc: build .dtb files in dts directory").
>
> Which I think means the assignment to DTC_FLAGS in
> arch/powerpc/boot/Makefile is not needed anymore.
>
> Can you send a v2 removing that assignment and explaining that's what
> happened?
I've wanted to make this common, but I guess that's a separate change.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-07 19:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-03 2:04 [PATCH] powerpc/dts: fix not include DTC_FLAGS Youlin Song
2021-04-07 11:27 ` Michael Ellerman
2021-04-07 19:58 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox