From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76151C433ED for ; Sat, 3 Apr 2021 09:43:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45E686120F for ; Sat, 3 Apr 2021 09:43:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236037AbhDCJm4 (ORCPT ); Sat, 3 Apr 2021 05:42:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232178AbhDCJmy (ORCPT ); Sat, 3 Apr 2021 05:42:54 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA3A6C0613E6 for ; Sat, 3 Apr 2021 02:42:51 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id 12so3471747wmf.5 for ; Sat, 03 Apr 2021 02:42:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=manp5WyYRzbgV7XgwB1/gokIu0V9Lu5KMjavj/C4ckc=; b=hJWUrzJhx6M+X7GDYaopIwPDuDKw0dmRqDXfY2338Repp9jCvo96MoaxsCkVoiwOK7 3sMCpFxjNSHvRCfXZ2roJnUymm3q2KflGxgswnDs5wHMSbNlFEO9AxFmiLc76olzLVb6 dDCDEQ8ejlbTO57JHH4UNKogGDJqZDBWAnAuUXjUNUJhv1SbvSjuAIYc6PpPJqAMbsUm E5m6o3QYBgCFTf0G4PoauRqss7044jx1sUp0VqWQzD0EgU5uenckgTdEG2xsNMoglKfw GsiY1fD++IFoDmJc6AC+VaYFvitounvhAVSaD1h19qqDIn7hOzSb4i+rwpo7oziqG0jg wSDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=manp5WyYRzbgV7XgwB1/gokIu0V9Lu5KMjavj/C4ckc=; b=VfbFVq5bkWmw+Ld+uwK/lAA7xNr4qmTr0oqELKyOf2wOFbrrEfrGzD3ttXPsZHWEmf c9lKbLuwPCQk1iWFtWI1mnOGi7xYohCUghsEhgycaoZqnwGuKvl1EQZck8PfsTQ3BCxc nK62w8HbVxaOiEmzzIOmjtwuW9GXidh7d6iBi6kYdBB8D5zfXxIF7mPZ3q4C+uBSeF4s zvgJLMkrVFD2uF2GWpeQ+G5lO9sAOuGda1jLmyx1koBHbXTkfFPA2L9wvi3AfzZdWCLv K7OF0vgGjN4SA15KyxSJAKmt3nfScqbuXYEd45B17uJ/uHZ2PFfGmoNKYNdOzr4d3Hcj o76Q== X-Gm-Message-State: AOAM530rElEwW263IPSpH1K5npptD4zJuZPouxu4I+GAuYisZYHWpCLv g/mIGAuw7dbXgnZ4TAlyMMw= X-Google-Smtp-Source: ABdhPJynMj+T3YGzHJlD68A+g2yJx6TTX69kgc56uCkOrvrPBj/ui/93zw2CGdvgD3+FSrUhLnBFsA== X-Received: by 2002:a05:600c:259:: with SMTP id 25mr16959940wmj.5.1617442970643; Sat, 03 Apr 2021 02:42:50 -0700 (PDT) Received: from agape.jhs ([5.171.72.64]) by smtp.gmail.com with ESMTPSA id m3sm18083541wme.40.2021.04.03.02.42.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Apr 2021 02:42:50 -0700 (PDT) Date: Sat, 3 Apr 2021 11:42:47 +0200 From: Fabio Aiuto To: dan.carpenter@oracle.com Cc: gregkh@linuxfoundation.org, joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 16/30] staging: rtl8723bs: tidy up some error handling in core/rtw_mlme.c Message-ID: <20210403094247.GC1563@agape.jhs> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 03, 2021 at 11:13:38AM +0200, Fabio Aiuto wrote: > the RT_TRACE() output is not useful so we want to delete it. In this case > there is no cleanup for rtw_cleanbss_cmd() required or even possible. I've > deleted the RT_TRACE() output and added a goto unlock to show > that we can't continue if rtw_createbss_cmd() fails. > > Suggested-by: David Carpenter > Signed-off-by: Fabio Aiuto > --- > drivers/staging/rtl8723bs/core/rtw_mlme.c | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) Hi Dan, I put a Suggested-by tag on one patch in v3 patchset. But reading the docs on submitting patches I relaized later that maybe it requires your permission before. It' written about Reviewed-by but not about Suggested-by, should I have asked you before, should I? I'm sorry if I should have. thank you, fabio