From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 606C9C433ED for ; Sat, 3 Apr 2021 09:50:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C18D611BF for ; Sat, 3 Apr 2021 09:50:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236149AbhDCJum (ORCPT ); Sat, 3 Apr 2021 05:50:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232178AbhDCJui (ORCPT ); Sat, 3 Apr 2021 05:50:38 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7559C0613E6 for ; Sat, 3 Apr 2021 02:50:34 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id q26so897850wrz.9 for ; Sat, 03 Apr 2021 02:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BsuX244Qwo5U14rjmt302Jci2DoZxQVAfqhH3h6HqLE=; b=E/Y+lZfdQok49SrEQ0ilEV83pkM0lBsRaVK4hSZWm2uuJja8OO+6SEKBfvCinRi173 GOSdXrvumuOIM374gfHoI/7UX2JKxSozXhueTsMElNqu7LqCZeNPy0X5BDbDjEbeYzF9 FJFr4bP2eOJjz+pp27ZHwNkkANcYAv9kFuSFXhAk4WssKRB8wrlr9BCRxdVYNL2jtDaz Wh/T62sv7aEexAX1qjLCQtSeo3fzeceBAQ/6qpOGoxCnkArTEz8tzz7qnn1GuJj06CyF vBoZrkVXXvnW48j3/hYxgD7oxwXqTWXVKshJwuHQu6T9NpZERBuEKBxzlSWAxW5PI28Z Y4dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BsuX244Qwo5U14rjmt302Jci2DoZxQVAfqhH3h6HqLE=; b=EhIQeJycWB0vlZKLxx0hjCEVM2boLqb2HUPaQ2KDXL1+zYg9lW0nRFxvG/NEDjH9bP YDahCs8sxWV+zptx7bft/lGwY2AneFoTv323K/8nmEJgWCpWT8G1dh9EILJNP4+2LS4O hsQyuzR4faEu77HPQX0bUBTK2wYZ55OFuV0CkqCUP+TFRLOR6osOfBGVZQGVMZZAMIPQ s+rDejXdGYrf3UhjC1ViTTMTCIZEGPlyETtvtPYOpq4cRr4+qWUa5KsRFD8VL3BvmZV+ ZHhNW+5Y/SFnmNI4ggGqB3KrCmxKSM75akUXjyHqWB8fbfqjwYxm2Ybad2XIoTY7UxAe Zg7g== X-Gm-Message-State: AOAM532+IP1rv4P+uEvHts4xCdHZrVpyvp26bh66kuZedqiMMp4l211Q gq0BRI91x+fmthxz11TmavI= X-Google-Smtp-Source: ABdhPJyftwBaOHZfgx34qVXAjk+Abj+CNEOgp1rC+jypa7eQC/o6R3jpjsduR/osuXKXZ6TtpMB8DA== X-Received: by 2002:adf:a1d8:: with SMTP id v24mr18987172wrv.378.1617443433390; Sat, 03 Apr 2021 02:50:33 -0700 (PDT) Received: from agape.jhs ([5.171.72.64]) by smtp.gmail.com with ESMTPSA id g16sm19513787wrs.76.2021.04.03.02.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Apr 2021 02:50:33 -0700 (PDT) Date: Sat, 3 Apr 2021 11:50:30 +0200 From: Fabio Aiuto To: dan.carpenter@oracle.com Cc: gregkh@linuxfoundation.org, joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 16/30] staging: rtl8723bs: tidy up some error handling in core/rtw_mlme.c Message-ID: <20210403095029.GD1563@agape.jhs> References: <20210403094247.GC1563@agape.jhs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210403094247.GC1563@agape.jhs> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 03, 2021 at 11:42:47AM +0200, Fabio Aiuto wrote: > On Sat, Apr 03, 2021 at 11:13:38AM +0200, Fabio Aiuto wrote: > > the RT_TRACE() output is not useful so we want to delete it. In this case > > there is no cleanup for rtw_cleanbss_cmd() required or even possible. I've > > deleted the RT_TRACE() output and added a goto unlock to show > > that we can't continue if rtw_createbss_cmd() fails. > > > > Suggested-by: David Carpenter > > Signed-off-by: Fabio Aiuto > > --- > > drivers/staging/rtl8723bs/core/rtw_mlme.c | 17 +++++++++++------ > > 1 file changed, 11 insertions(+), 6 deletions(-) > > Hi Dan, > > I put a Suggested-by tag on one patch in v3 patchset. But reading the docs > on submitting patches I relaized later that maybe it requires your permission before. > > It' written about Reviewed-by but not about Suggested-by, should I have asked you before, should I? > > I'm sorry if I should have. Found it, I'm really sorry A Suggested-by: tag indicates that the patch idea is suggested by the person named and ensures credit to the person for the idea. Please note that this tag should not be added without the reporter's permission, especially if the idea was not posted in a public forum. That said, if we diligently credit our idea reporters, they will, hopefully, be inspired to help us again in the future. I wonder if in the case of this patch was needed this tag.. > > thank you, > > fabio regards, fabio