* [PATCH] doc: Fix mistaken diagram references in RCU
@ 2021-04-04 21:58 Frederic Weisbecker
2021-04-05 0:29 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Frederic Weisbecker @ 2021-04-04 21:58 UTC (permalink / raw)
To: Paul E . McKenney; +Cc: LKML, Frederic Weisbecker
The 3 diagrams describing rcu_gp_init() all spuriously refer to the same
figure, probably due to some copy/paste issue. Fix the references.
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
---
.../RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst b/Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst
index 3f6ce41ee0c5..11cdab037bff 100644
--- a/Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst
+++ b/Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst
@@ -339,14 +339,14 @@ The diagram below shows the path of ordering if the leftmost
leftmost ``rcu_node`` structure offlines its last CPU and if the next
``rcu_node`` structure has no online CPUs).
-.. kernel-figure:: TreeRCU-gp-init-1.svg
+.. kernel-figure:: TreeRCU-gp-init-2.svg
The final ``rcu_gp_init()`` pass through the ``rcu_node`` tree traverses
breadth-first, setting each ``rcu_node`` structure's ``->gp_seq`` field
to the newly advanced value from the ``rcu_state`` structure, as shown
in the following diagram.
-.. kernel-figure:: TreeRCU-gp-init-1.svg
+.. kernel-figure:: TreeRCU-gp-init-3.svg
This change will also cause each CPU's next call to
``__note_gp_changes()`` to notice that a new grace period has started,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] doc: Fix mistaken diagram references in RCU
2021-04-04 21:58 [PATCH] doc: Fix mistaken diagram references in RCU Frederic Weisbecker
@ 2021-04-05 0:29 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2021-04-05 0:29 UTC (permalink / raw)
To: Frederic Weisbecker; +Cc: LKML
On Sun, Apr 04, 2021 at 11:58:43PM +0200, Frederic Weisbecker wrote:
> The 3 diagrams describing rcu_gp_init() all spuriously refer to the same
> figure, probably due to some copy/paste issue. Fix the references.
>
> Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Good catch, queued, thank you!
Thanx, Paul
> ---
> .../RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst b/Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst
> index 3f6ce41ee0c5..11cdab037bff 100644
> --- a/Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst
> +++ b/Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst
> @@ -339,14 +339,14 @@ The diagram below shows the path of ordering if the leftmost
> leftmost ``rcu_node`` structure offlines its last CPU and if the next
> ``rcu_node`` structure has no online CPUs).
>
> -.. kernel-figure:: TreeRCU-gp-init-1.svg
> +.. kernel-figure:: TreeRCU-gp-init-2.svg
>
> The final ``rcu_gp_init()`` pass through the ``rcu_node`` tree traverses
> breadth-first, setting each ``rcu_node`` structure's ``->gp_seq`` field
> to the newly advanced value from the ``rcu_state`` structure, as shown
> in the following diagram.
>
> -.. kernel-figure:: TreeRCU-gp-init-1.svg
> +.. kernel-figure:: TreeRCU-gp-init-3.svg
>
> This change will also cause each CPU's next call to
> ``__note_gp_changes()`` to notice that a new grace period has started,
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-05 0:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-04 21:58 [PATCH] doc: Fix mistaken diagram references in RCU Frederic Weisbecker
2021-04-05 0:29 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox