From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D748C433B4 for ; Sun, 4 Apr 2021 22:26:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 615226138B for ; Sun, 4 Apr 2021 22:26:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231638AbhDDW0D (ORCPT ); Sun, 4 Apr 2021 18:26:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230286AbhDDWZw (ORCPT ); Sun, 4 Apr 2021 18:25:52 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFF50C061756 for ; Sun, 4 Apr 2021 15:25:47 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id d8so4798851plh.11 for ; Sun, 04 Apr 2021 15:25:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=F/7g2yV6C0TwPD0bZdc4Di1ysJWXNJ5iWAZlkKHzvSA=; b=nL1c30ebIdWauZnz3Lpr2bZvGu96omS5WWVM+2LqIZG9rDqd27Ib5sNh6Ddc23E81u 9VqfUx7Amwv1TGw16o5cAG1wuOY0j1C0xcmiYAqduOSPegj1ke/PJWOYHYMueygFZXog MJ0iC8dyi3RSlRLtOSRJc5iO4mH8iXC1aeDWsafr+2bQnYaV/rKQZ0lO+acaEBE0hTYK /3A9FrwOmn0bmN3Wno2l3Saev8ArzwzU7ApaAbTsRbIO2mL7stLhEdQwI4c+0zHlqK0j Vd+9szex07PUeKZNSi7bk7E4BrQxMC5KYRO5IhcaI3th+dpVLkHnft324AGn15atPtJg o30Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=F/7g2yV6C0TwPD0bZdc4Di1ysJWXNJ5iWAZlkKHzvSA=; b=nI3lApHAQhjitmtryWhn1LjaOPkZTQ2p4P5CZ3cHKoheaNHHdwEKB5l//BSmwgWTya AEFabvvCqTQcr6mIFAp06BqHEijek+5qtywASP4VLewZi8STgyOqlCJNxjm8v9LY368j +IGXqjb0PAZHE8PuN5TBGYgOAjUIuaQhpg8bK/W7xAQqlwdOQwUen8kKocl69WMi+Ahg 0bVU+Lts6+j5vfVA0lkIM7WdpCLbClSqHw2Ly/ffNKgVXOJIEHEjIZ4bpzxZgOHPjgjG fwudNaRHjzeX9Flci3mj9hVOjXW0najJVdrzcsSt2Zyb8BkZ7s1R6A0eiG0ivZC0bn/S pbTg== X-Gm-Message-State: AOAM53342qTJDgZ7rCIC8QFm4TcfjgCjn1HcK5t360SpNK5UjuN4Vu9n Fd/hAg9vLYV8NfaxZk56aUpPlqmDPwayQA== X-Google-Smtp-Source: ABdhPJztRI1GKQ6cBjL7nuv43wzB8EfdESuPd2pfW2tM0FExBRveKn68qybiF6350Z5puzNTFR4GrQ== X-Received: by 2002:a17:90b:3615:: with SMTP id ml21mr23515091pjb.72.1617575147253; Sun, 04 Apr 2021 15:25:47 -0700 (PDT) Received: from djbComp (S0106ac202ecb0523.gv.shawcable.net. [70.67.120.89]) by smtp.gmail.com with ESMTPSA id bx2sm2327191pjb.32.2021.04.04.15.25.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Apr 2021 15:25:47 -0700 (PDT) Date: Sun, 4 Apr 2021 15:25:45 -0700 From: Deborah Brouwer To: Greg KH Cc: Larry.Finger@lwfinger.net, straube.linux@gmail.com, unixbhaskar@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [PATCH] staging: rtl8188eu: replace goto with direct return Message-ID: <20210404222545.GA7267@djbComp> References: <20210404054008.23525-1-deborahbrouwer3563@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 04, 2021 at 11:54:40AM +0200, Greg KH wrote: > On Sat, Apr 03, 2021 at 10:40:08PM -0700, Deborah Brouwer wrote: > > To conform with Linux kernel coding style, replace goto statement that > > does no cleanup with a direct return. To preserve meaning, copy comments > > from the original goto statement to the return statement. Identified by > > the checkpatch warning: WARNING: void function return statements are not > > generally useful. > > > > Signed-off-by: Deborah Brouwer > > --- > > drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c > > index 391c59490718..d21f21857c20 100644 > > --- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c > > +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c > > @@ -139,7 +139,9 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter) > > hw_init_completed = Adapter->hw_init_completed; > > > > if (!hw_init_completed) > > - goto skip_dm; > > + /* Check GPIO to determine current RF on/off and Pbc status. */ > > + /* Check Hardware Radio ON/OFF or not */ > > + return; > > It does not make sense to have the comments in two places here. The > original code is just fine, there's nothing wrong with the goto > statement here. > > thanks, > > greg k-h Ok, thanks for this feedback.