Re: [PATCH 5.10 004/126] ext4: shrink race window in ext4_should_retry_alloc()

Eric Whitney
2021-04-06T21:11:32Z

* Pavel Machek <pavel@ucw.cz>:
> Hi!
>
> > From: Eric Whitney <enwlinux@gmail.com>
>
> > A per filesystem percpu counter exported via sysfs is added to allow
> > users or developers to track the number of times the retry limit is
> > exceeded without resorting to debugging methods. This should provide
> > some insight into worst case retry behavior.
>
> This adds new counter exported via sysfs, but no documentation of that
> counter...
>
> Best regards,
> Pavel
>

Thanks for the observation. I'll check with Ted to see what he'd like.

Eric

> > @@ -257,6 +259,7 @@ static struct attribute *ext4_attrs[] = {
> > ATTR_LIST(session_write_kbytes),
> > ATTR_LIST(lifetime_write_kbytes),
> > ATTR_LIST(reserved_clusters),
> > + ATTR_LIST(sra_exceeded_retry_limit),
> > ATTR_LIST(inode_readahead_blks),
> > ATTR_LIST(inode_goal),
> > ATTR_LIST(mb_stats),
>
> --
> http://www.livejournal.com/~pavelmachek