From: Daniel Winkler <danielwinkler@google.com>
To: marcel@holtmann.org, linux-bluetooth@vger.kernel.org
Cc: chromeos-bluetooth-upstreaming@chromium.org,
Daniel Winkler <danielwinkler@google.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH 0/2] Bluetooth: Avoid centralized adv handle tracking for extended features
Date: Mon, 5 Apr 2021 16:33:03 -0700 [thread overview]
Message-ID: <20210405233305.92431-1-danielwinkler@google.com> (raw)
Hi Maintainers,
This series addresses a race condition where an advertisement
registration can conflict with a software rotation advertisement
refresh. I found that this issue was only occurring with the new
extended MGMT advertising interface. A bad use of the
hdev->cur_adv_instance caused every new instance to be immediately sent
to the controller rather than queued for software rotation, opening a
path for the race to occur.
This series improves the way new extended advertising hci callbacks
track the relevant adv handle, removing the need for the
cur_adv_instance use. In a separate patch, the incorrect usage of
cur_adv_instance is removed, to align the extended MGMT commands to the
original add_advertising usage. The series was tested on both extended
and non-extended bluetooth controllers to confirm that the race
condition is resolved, and that multi- and single-advertising automated
test scenarios are still successful.
Thanks in advance,
Daniel
Daniel Winkler (2):
Bluetooth: Use ext adv handle from requests in CCs
Bluetooth: Do not set cur_adv_instance in adv param MGMT request
net/bluetooth/hci_event.c | 16 +++++++---------
net/bluetooth/mgmt.c | 1 -
2 files changed, 7 insertions(+), 10 deletions(-)
--
2.31.0.208.g409f899ff0-goog
next reply other threads:[~2021-04-05 23:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 23:33 Daniel Winkler [this message]
2021-04-05 23:33 ` [PATCH 1/2] Bluetooth: Use ext adv handle from requests in CCs Daniel Winkler
2021-04-05 23:33 ` [PATCH 2/2] Bluetooth: Do not set cur_adv_instance in adv param MGMT request Daniel Winkler
2021-04-06 8:44 ` [PATCH 0/2] Bluetooth: Avoid centralized adv handle tracking for extended features Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210405233305.92431-1-danielwinkler@google.com \
--to=danielwinkler@google.com \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=davem@davemloft.net \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox