From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/4] MIPS: Remove get_fs/set_fs
Date: Tue, 6 Apr 2021 15:01:33 +0200 [thread overview]
Message-ID: <20210406130133.GB9505@alpha.franken.de> (raw)
In-Reply-To: <20210406072443.GA7626@lst.de>
On Tue, Apr 06, 2021 at 09:24:43AM +0200, Christoph Hellwig wrote:
> Btw, there is a bunch of cleanups that would fit in nicely on top of
> this:
>
> - remove the unused __invoke_copy_from function
I've removed in the last patch before applying to mips-next.
> - fold __get_user_check into get_user as it is the only caller
> - fold __get_user_nocheck into __get_user as it is the only caller
> - fold __put_user_check into put_user as it is the only caller
> - fold __put_user_nocheck into __put_user as it is the only caller
> - implement get_user in terms of __get_user to document the difference
> better and to remove __get_user_common
> - implement put_user in terms of __put_user to document the difference
> better and to remove __get_user_common
> - remove __put_user_unknown/__get_user_unknown and replace them with
> BUILD_BUG_ON()
I'll prepare a follow-up patch. Thank you for your cleanup hints.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2021-04-06 13:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 12:56 [PATCH v3 0/4] MIPS: Remove get_fs/set_fs Thomas Bogendoerfer
2021-04-01 12:56 ` [PATCH v3 1/4] MIPS: kernel: Remove not needed set_fs calls Thomas Bogendoerfer
2021-04-01 12:56 ` [PATCH v3 2/4] MIPS: uaccess: Added __get/__put_kernel_nofault Thomas Bogendoerfer
2021-04-01 12:56 ` [PATCH v3 3/4] MIPS: uaccess: Remove get_fs/set_fs call sites Thomas Bogendoerfer
2021-04-01 14:04 ` Christoph Hellwig
2021-04-01 12:56 ` [PATCH v3 4/4] MIPS: Remove get_fs/set_fs Thomas Bogendoerfer
2021-04-01 14:05 ` Christoph Hellwig
2021-04-06 7:24 ` [PATCH v3 0/4] " Christoph Hellwig
2021-04-06 13:01 ` Thomas Bogendoerfer [this message]
2021-04-06 12:59 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210406130133.GB9505@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox