Re: [PATCH v6 23/27] mm/writeback: Add wait_on_folio_writeback

Christoph Hellwig
2021-04-06T14:18:38Z

On Wed, Mar 31, 2021 at 07:47:24PM +0100, Matthew Wilcox (Oracle) wrote:
> wait_on_page_writeback_killable() only has one caller, so convert it to
> call wait_on_folio_writeback_killable(). For the wait_on_page_writeback()
> callers, add a compatibility wrapper around wait_on_folio_writeback().
>
> Turning PageWriteback() into FolioWriteback() eliminates a call to
> compound_head() which saves 8 bytes and 15 bytes in the two functions.
> That is more than offset by adding the wait_on_page_writeback
> compatibility wrapper for a net increase in text of 15 bytes.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>