Re: [PATCH 3/3] USB: cdc-acm: fix TIOCGSERIAL implementation

Greg Kroah-Hartman
2021-04-08T12:08:05Z

On Thu, Apr 08, 2021 at 01:59:43PM +0200, Oliver Neukum wrote:
> Am Donnerstag, den 08.04.2021, 13:54 +0200 schrieb Johan Hovold:
> > On Thu, Apr 08, 2021 at 01:34:12PM +0200, Oliver Neukum wrote:
> > > Am Donnerstag, den 08.04.2021, 11:48 +0200 schrieb Johan Hovold:
> > > > On Thu, Apr 08, 2021 at 10:36:46AM +0200, Oliver Neukum wrote:
> > > > > Am Mittwoch, den 07.04.2021, 12:28 +0200 schrieb Johan Hovold:
> > > > > Well, the devices report it. It is part of the standard.
> > > >
> > > > No, the standard doesn't include anything about a baud-base clock
> > > > AFAICT.
> > >
> > > Unfortunately it does.
> > > dwDTERate - chapter 6.3.11 - table 17
> >
> > That's not the base clock rate, that's just the currently configured
> > line speed which you can read from termios
> > > If we does this wrongly, we should certainly fix it, but just removing
> > > the reporting doesn't look right to me.
> >
> > The driver got its interpretation of baud_base wrong, and CDC doesn't
> > even have a concept of base clock rate so removing it is the right thing
> > to do.
> >
> > Again, baud_base is really only relevant with legacy UARTs and when
> > using the deprecated ASYNC_SPD_CUST.
> >
> > And if the user wants to knows the current line speed we have a
> > different interface for that.
>
> Hi,
>
> thank you, that clarifies things. I am happy with the patch itself,
> but could I ask you to do two things:
>
> 1. Edit the commit description
> making clear that the difference
> between the base clock rate and the line speed.
>
> 2. Mark the patch specially to NOT be included in stable. We may
> have
> users misusing the current API.

That doesn't matter, if there are misusers then their use will "break"
on newer kernels. And if so, then it doesn't deserve to be in any
release.

If a change is good enough for Linus's tree, that means it is good
enough for a stable tree, the requirements are exactly the same when it
comes to userspace interactions.

thanks,

greg k-h