From: Johan Hovold <johan@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/4] USB: serial: ti_usb_3410_5052: switch to 30-second closing wait
Date: Wed, 7 Apr 2021 12:45:29 +0200 [thread overview]
Message-ID: <20210407104529.1110-5-johan@kernel.org> (raw)
In-Reply-To: <20210407104529.1110-1-johan@kernel.org>
Switch to using the system-wide default 30-second closing-wait timeout
instead of the driver specific 40-second timeout.
The timeout can be changed per port using TIOCSSERIAL (setserial) if
needed.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/usb/serial/ti_usb_3410_5052.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c
index 35cc1be738ef..03839289d6c0 100644
--- a/drivers/usb/serial/ti_usb_3410_5052.c
+++ b/drivers/usb/serial/ti_usb_3410_5052.c
@@ -270,8 +270,6 @@ struct ti_firmware_header {
#define TI_TRANSFER_TIMEOUT 2
-#define TI_DEFAULT_CLOSING_WAIT 4000 /* in .01 secs */
-
/* read urb states */
#define TI_READ_URB_RUNNING 0
#define TI_READ_URB_STOPPING 1
@@ -602,7 +600,6 @@ static int ti_port_probe(struct usb_serial_port *port)
tport->tp_uart_base_addr = TI_UART1_BASE_ADDR;
else
tport->tp_uart_base_addr = TI_UART2_BASE_ADDR;
- port->port.closing_wait = msecs_to_jiffies(10 * TI_DEFAULT_CLOSING_WAIT);
tport->tp_port = port;
tport->tp_tdev = usb_get_serial_data(port->serial);
--
2.26.3
next prev parent reply other threads:[~2021-04-07 10:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 10:45 [PATCH 0/4] USB: serial: closing-wait cleanups Johan Hovold
2021-04-07 10:45 ` [PATCH 1/4] USB: serial: io_ti: drop closing_wait module parameter Johan Hovold
2021-04-07 10:45 ` [PATCH 2/4] USB: serial: io_ti: switch to 30-second closing wait Johan Hovold
2021-04-07 10:45 ` [PATCH 3/4] USB: serial: ti_usb_3410_5052: drop closing_wait module parameter Johan Hovold
2021-04-07 10:45 ` Johan Hovold [this message]
2021-04-07 15:24 ` [PATCH 0/4] USB: serial: closing-wait cleanups Greg KH
2021-04-08 8:00 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210407104529.1110-5-johan@kernel.org \
--to=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox