* [PATCH -next] char: xilinx_hwicap: use DEFINE_MUTEX() for mutex lock
@ 2021-04-09 9:51 Ye Bin
2021-04-10 8:58 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Ye Bin @ 2021-04-09 9:51 UTC (permalink / raw)
To: yebin10, Arnd Bergmann, Greg Kroah-Hartman, Michal Simek
Cc: linux-arm-kernel, linux-kernel, kernel-janitors, Hulk Robot
mutex lock can be initialized automatically with DEFINE_MUTEX()
rather than explicitly calling mutex_init().
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
drivers/char/xilinx_hwicap/xilinx_hwicap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/char/xilinx_hwicap/xilinx_hwicap.c b/drivers/char/xilinx_hwicap/xilinx_hwicap.c
index 067396bedf22..4d586233dfa4 100644
--- a/drivers/char/xilinx_hwicap/xilinx_hwicap.c
+++ b/drivers/char/xilinx_hwicap/xilinx_hwicap.c
@@ -111,7 +111,7 @@
/* An array, which is set to true when the device is registered. */
static DEFINE_MUTEX(hwicap_mutex);
static bool probed_devices[HWICAP_DEVICES];
-static struct mutex icap_sem;
+static DEFINE_MUTEX(icap_sem);
static struct class *icap_class;
@@ -857,7 +857,6 @@ static int __init hwicap_module_init(void)
int retval;
icap_class = class_create(THIS_MODULE, "xilinx_config");
- mutex_init(&icap_sem);
devt = MKDEV(XHWICAP_MAJOR, XHWICAP_MINOR);
retval = register_chrdev_region(devt,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] char: xilinx_hwicap: use DEFINE_MUTEX() for mutex lock
2021-04-09 9:51 [PATCH -next] char: xilinx_hwicap: use DEFINE_MUTEX() for mutex lock Ye Bin
@ 2021-04-10 8:58 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-04-10 8:58 UTC (permalink / raw)
To: Ye Bin
Cc: Arnd Bergmann, Michal Simek, linux-arm-kernel, linux-kernel,
kernel-janitors, Hulk Robot
On Fri, Apr 09, 2021 at 05:51:36PM +0800, Ye Bin wrote:
> mutex lock can be initialized automatically with DEFINE_MUTEX()
> rather than explicitly calling mutex_init().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> ---
> drivers/char/xilinx_hwicap/xilinx_hwicap.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/char/xilinx_hwicap/xilinx_hwicap.c b/drivers/char/xilinx_hwicap/xilinx_hwicap.c
> index 067396bedf22..4d586233dfa4 100644
> --- a/drivers/char/xilinx_hwicap/xilinx_hwicap.c
> +++ b/drivers/char/xilinx_hwicap/xilinx_hwicap.c
> @@ -111,7 +111,7 @@
> /* An array, which is set to true when the device is registered. */
> static DEFINE_MUTEX(hwicap_mutex);
> static bool probed_devices[HWICAP_DEVICES];
> -static struct mutex icap_sem;
> +static DEFINE_MUTEX(icap_sem);
>
> static struct class *icap_class;
>
> @@ -857,7 +857,6 @@ static int __init hwicap_module_init(void)
> int retval;
>
> icap_class = class_create(THIS_MODULE, "xilinx_config");
> - mutex_init(&icap_sem);
>
> devt = MKDEV(XHWICAP_MAJOR, XHWICAP_MINOR);
> retval = register_chrdev_region(devt,
>
What actually does this help out with? Why is it wrong to explicitly
call mutex_init() instead of a magic macro?
What good are these changes causing?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-10 8:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-09 9:51 [PATCH -next] char: xilinx_hwicap: use DEFINE_MUTEX() for mutex lock Ye Bin
2021-04-10 8:58 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox