* Re: [PATCH] hwmon: (dell-smm) Add Dell Latitude 7440 to fan control whitelist [not found] <EE8F83B0-0C39-4E2A-B5FB-B94A1389588D@icloud.com> @ 2021-03-31 10:02 ` Pali Rohár 2021-03-31 17:03 ` Guenter Roeck 2021-04-09 23:21 ` Guenter Roeck 1 sibling, 1 reply; 3+ messages in thread From: Pali Rohár @ 2021-03-31 10:02 UTC (permalink / raw) To: Sebastian Oechsle, Guenter Roeck; +Cc: jdelvare, linux-hwmon, linux-kernel On Tuesday 30 March 2021 19:02:55 Sebastian Oechsle wrote: > Allow manual PWM control on Dell Latitude 7440. > > Signed-off-by: Sebastian Oechsle <setboolean@icloud.com <mailto:setboolean@icloud.com>> Reviewed-by: Pali Rohár <pali@kernel.org> (Btw, in commit message is small typo, model name is E7440, not 7440) Guenter, would you take this patch? > --- > drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c > index 73b9db9e3aab..2970892bed82 100644 > --- a/drivers/hwmon/dell-smm-hwmon.c > +++ b/drivers/hwmon/dell-smm-hwmon.c > @@ -1210,6 +1210,14 @@ static struct dmi_system_id i8k_whitelist_fan_control[] __initdata = { > }, > .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3], > }, > + { > + .ident = "Dell Latitude E7440", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude E7440"), > + }, > + .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3], > + }, > { } > }; > > -- > 2.31.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon: (dell-smm) Add Dell Latitude 7440 to fan control whitelist 2021-03-31 10:02 ` [PATCH] hwmon: (dell-smm) Add Dell Latitude 7440 to fan control whitelist Pali Rohár @ 2021-03-31 17:03 ` Guenter Roeck 0 siblings, 0 replies; 3+ messages in thread From: Guenter Roeck @ 2021-03-31 17:03 UTC (permalink / raw) To: Pali Rohár; +Cc: Sebastian Oechsle, jdelvare, linux-hwmon, linux-kernel On Wed, Mar 31, 2021 at 12:02:11PM +0200, Pali Rohár wrote: > On Tuesday 30 March 2021 19:02:55 Sebastian Oechsle wrote: > > Allow manual PWM control on Dell Latitude 7440. > > > > Signed-off-by: Sebastian Oechsle <setboolean@icloud.com <mailto:setboolean@icloud.com>> > > Reviewed-by: Pali Rohár <pali@kernel.org> > > (Btw, in commit message is small typo, model name is E7440, not 7440) > > Guenter, would you take this patch? > I'll take it. Guenter > > --- > > drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c > > index 73b9db9e3aab..2970892bed82 100644 > > --- a/drivers/hwmon/dell-smm-hwmon.c > > +++ b/drivers/hwmon/dell-smm-hwmon.c > > @@ -1210,6 +1210,14 @@ static struct dmi_system_id i8k_whitelist_fan_control[] __initdata = { > > }, > > .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3], > > }, > > + { > > + .ident = "Dell Latitude E7440", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude E7440"), > > + }, > > + .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3], > > + }, > > { } > > }; > > > > -- > > 2.31.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon: (dell-smm) Add Dell Latitude 7440 to fan control whitelist [not found] <EE8F83B0-0C39-4E2A-B5FB-B94A1389588D@icloud.com> 2021-03-31 10:02 ` [PATCH] hwmon: (dell-smm) Add Dell Latitude 7440 to fan control whitelist Pali Rohár @ 2021-04-09 23:21 ` Guenter Roeck 1 sibling, 0 replies; 3+ messages in thread From: Guenter Roeck @ 2021-04-09 23:21 UTC (permalink / raw) To: Sebastian Oechsle; +Cc: pali, jdelvare, linux-hwmon, linux-kernel On Tue, Mar 30, 2021 at 07:02:55PM +0200, Sebastian Oechsle wrote: > Allow manual PWM control on Dell Latitude 7440. > > Signed-off-by: Sebastian Oechsle <setboolean@icloud.com <mailto:setboolean@icloud.com>> This patch is corrupt, to the point where it doesn't show up in hwmon patchwork. I just happened to find it, but I can not convince git to apply it. Please fix the problem and resubmit. Thanks, Guenter > --- > drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c > index 73b9db9e3aab..2970892bed82 100644 > --- a/drivers/hwmon/dell-smm-hwmon.c > +++ b/drivers/hwmon/dell-smm-hwmon.c > @@ -1210,6 +1210,14 @@ static struct dmi_system_id i8k_whitelist_fan_control[] __initdata = { > }, > .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3], > }, > + { > + .ident = "Dell Latitude E7440", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude E7440"), > + }, > + .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3], > + }, > { } > }; > > -- > 2.31.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-09 23:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <EE8F83B0-0C39-4E2A-B5FB-B94A1389588D@icloud.com>
2021-03-31 10:02 ` [PATCH] hwmon: (dell-smm) Add Dell Latitude 7440 to fan control whitelist Pali Rohár
2021-03-31 17:03 ` Guenter Roeck
2021-04-09 23:21 ` Guenter Roeck
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox