From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17543C43460 for ; Mon, 12 Apr 2021 08:28:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DCEA9611AD for ; Mon, 12 Apr 2021 08:28:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237327AbhDLI20 (ORCPT ); Mon, 12 Apr 2021 04:28:26 -0400 Received: from verein.lst.de ([213.95.11.211]:47587 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237284AbhDLI2Y (ORCPT ); Mon, 12 Apr 2021 04:28:24 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 856F868C4E; Mon, 12 Apr 2021 10:28:05 +0200 (CEST) Date: Mon, 12 Apr 2021 10:28:05 +0200 From: Christoph Hellwig To: Peter Zijlstra Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, x86@kernel.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, chris@chris-wilson.co.uk, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, keescook@chromium.org, hch@lst.de Subject: Re: [PATCH 4/7] mm: Introduce verify_page_range() Message-ID: <20210412082805.GD4372@lst.de> References: <20210412080012.357146277@infradead.org> <20210412080611.769864829@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210412080611.769864829@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 12, 2021 at 10:00:16AM +0200, Peter Zijlstra wrote: > +extern int verify_page_range(struct mm_struct *mm, No need for the extern here. > +int verify_page_range(struct mm_struct *mm, > + unsigned long addr, unsigned long size, > + int (*fn)(pte_t pte, unsigned long addr, void *data), > + void *data) A kerneldoc comment would be nice for this function. Otherwise this looks fine.