Re: [PATCH 1/2] dt-bindings: iio: accel: Add SCA3300 documentation

Rob Herring
2021-04-12T21:02:24Z

On Mon, Apr 12, 2021 at 10:50:55AM +0300, Tomas Melin wrote:
> initial DT bindings for Murata SCA3300 Accelerometer.
>
> Signed-off-by: Tomas Melin <tomas.melin@vaisala.com>
> ---
> .../bindings/iio/accel/sca3300.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/accel/sca3300.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/sca3300.yaml b/Documentation/devicetree/bindings/iio/accel/sca3300.yaml
> new file mode 100644
> index 000000000000..32fe4b647cd0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/accel/sca3300.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only)

For new bindings:

GPL-2.0-only OR BSD-2-Clause

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/accel/sca3300.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Murata SCA3300 Accelerometer
> +
> +description: |
> + 3-axis industrial accelerometer with digital SPI interface
> + https://www.murata.com/en-global/products/sensor/accel/sca3300
> +
> +maintainers:
> + - Tomas Melin <tomas.melin@vaisala.com>
> +
> +properties:
> + compatible:
> + enum:
> + - murata,sca3300
> +
> + reg:
> + maxItems: 1
> + description: SPI chip select number according to the general SPI bindings
> +
> + spi-max-frequency:
> + maximum: 8000000
> +
> + murata,opmode:
> + description: Accelerometer operation mode as described in datasheet (MODE)
> + $ref: /schemas/types.yaml#/definitions/uint32

0 - 2^32 are all valid modes?

> +
> +required:
> + - compatible
> + - reg
> + - murata,opmode
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + sca3300@0 {

accelerometer@0

> + compatible = "murata,sca3300";
> + reg = <0x0>;
> + spi-max-frequency = <4000000>;
> + murata,opmode = <4>;
> + };
> + };
> +...
> --
> 2.21.3
>