From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B54EC433B4 for ; Mon, 12 Apr 2021 11:57:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56A716100C for ; Mon, 12 Apr 2021 11:57:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240773AbhDLL5m (ORCPT ); Mon, 12 Apr 2021 07:57:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239202AbhDLL5k (ORCPT ); Mon, 12 Apr 2021 07:57:40 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18800C061574 for ; Mon, 12 Apr 2021 04:57:22 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id p6so5912752wrn.9 for ; Mon, 12 Apr 2021 04:57:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=26Z5+AmQkQeLw9JlKRYpbSMEomtaV7uiUzdp3tF/h3M=; b=QAHqM7KtRWGaWyiVCAKHTW2n3QGFWLMbRDJsG5wuUJqDMRPZPh9ojwb8/tvpQUCCEV rJku7h1V3GZXTEZIe8Cgxtw8rffogTunu7W7ND4cPloyb1PF1e0GUrI3Fh+OcPWw2MTs 3RMdQJ+RaoFPxouPWZ+LvyRouvZwJdxoVulvwoipA8sbNQHXol287cyIW0LVW5Ggllsb HGnmGXRayG2YXMXHE2MXBPfFIfTp4kvnSSM400FEgOErBHbWvbG81LXE/AUIHIle8cmk qSEzOMhxwcqiIVlqGN30YilqID37lcUM07Te7rZtO7T0Kr7ZT/1BoZTvSOWkIanbtwWn Yi5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=26Z5+AmQkQeLw9JlKRYpbSMEomtaV7uiUzdp3tF/h3M=; b=FP84iHBSzyxSwH5dKUo9MzLyKo7BEt0CSTreN84/PA9bz1m52jepRWbkaNBCeZsHkB n2cf89zsh9bQOSF2FiarLosXYlFjfE5uSh4tbXavBPVkHE8dcUluqSTw6qq/0DTVMv97 c42B7cFCnfWG3uuxsfUrcRnJH2ugdnCdaU8Q6npsNRAeRIjek1o8+C6JIcc4Vd+UQlqr O7u8H7f5p2ZGOjsp6+TcD6pEf5QRr8oN4YHavM5AN2aTB3W4rxsTH64dhc3/sdMgFL/H m8DffZh4ViyiqvoataIYIuMgt/pZQetRc8n8M/KlXfTNkv/YIn7HqE1SMQmDG4aeF3Iw RM6g== X-Gm-Message-State: AOAM532/rVlZNZhHLxlEljJDTSchfngIWb+4pKG9zafnMZUNt9g+sMbk WZ9N5bjRBisoMmSDNRm254qMSIqafuaJIg== X-Google-Smtp-Source: ABdhPJzECpBATP6pixPwCmw6QQc3EYzQxea8Rcf5D2cpeRFwqgeCxZexC0oGlzoXDGHHIcixFzV9Kw== X-Received: by 2002:a05:6000:24f:: with SMTP id m15mr8982690wrz.226.1618228640852; Mon, 12 Apr 2021 04:57:20 -0700 (PDT) Received: from agape.jhs ([5.171.81.2]) by smtp.gmail.com with ESMTPSA id s64sm8909285wmf.2.2021.04.12.04.57.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 04:57:20 -0700 (PDT) Date: Mon, 12 Apr 2021 13:57:17 +0200 From: Fabio Aiuto To: Greg KH Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, lkp@intel.com Subject: Re: [PATCH 1/3] staging: rtl8723bs: remove unused variable ret in hal/sdio_halinit.c Message-ID: <20210412115716.GA1415@agape.jhs> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 12, 2021 at 11:38:48AM +0200, Greg KH wrote: > On Sun, Apr 11, 2021 at 02:57:35PM +0200, Fabio Aiuto wrote: > > fix following compiler warning issue: > > > > drivers/staging/rtl8723bs/hal/sdio_halinit.c: > > In function 'CardDisableRTL8723BSdio': > > >> drivers/staging/rtl8723bs/hal/sdio_halinit.c:881:5: > > warning: variable 'ret' set but not used [-Wunused-but-set-variable] > > 881 | u8 ret = _FAIL; > > | ^~~ > > > > Reported-by: kernel test robot > > Signed-off-by: Fabio Aiuto > > --- > > drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c > > index 2098384efe92..936181a73d73 100644 > > --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c > > +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c > > @@ -878,10 +878,9 @@ static void CardDisableRTL8723BSdio(struct adapter *padapter) > > { > > u8 u1bTmp; > > u8 bMacPwrCtrlOn; > > - u8 ret = _FAIL; > > > > /* Run LPS WL RFOFF flow */ > > - ret = HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, rtl8723B_enter_lps_flow); > > + HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, rtl8723B_enter_lps_flow); > > > > /* ==== Reset digital sequence ====== */ > > > > @@ -909,9 +908,8 @@ static void CardDisableRTL8723BSdio(struct adapter *padapter) > > /* ==== Reset digital sequence end ====== */ > > > > bMacPwrCtrlOn = false; /* Disable CMD53 R/W */ > > - ret = false; > > rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn); > > - ret = HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, rtl8723B_card_disable_flow); > > + HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, rtl8723B_card_disable_flow); > > } > > Why isn't the return value being checked and returned to the caller if > something goes wrong? Ignoring it feels wrong to me. > > thanks, > > greg k-h ok, I will propagate the return value to the whole caller chain. CardDisableRTL8723BSdio returns void, will change this to u8... thank you, fabio