From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68615C433B4 for ; Mon, 12 Apr 2021 16:01:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 356BF61278 for ; Mon, 12 Apr 2021 16:01:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243198AbhDLQBm (ORCPT ); Mon, 12 Apr 2021 12:01:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243189AbhDLQBj (ORCPT ); Mon, 12 Apr 2021 12:01:39 -0400 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E72DC06174A for ; Mon, 12 Apr 2021 09:01:20 -0700 (PDT) Received: by mail-ot1-x331.google.com with SMTP id t23-20020a0568301e37b02901b65ab30024so13264405otr.4 for ; Mon, 12 Apr 2021 09:01:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5CtEYzn7kIwgucylcxTz9N8ey3nUOdntfUbQ88bxuCE=; b=f+N61ZZEKv3sMaFIhuG/mjI1//fMUJZYO6yOBVZ7MxDa5r9bneo8QNZeQfgypRXxbP wtlu0EOAlLpFfy/BCPC+mA4AqQCbsc6Y0Zl5kQi0SXblVNBu2tXIw2LnuHYj/aFeu1N3 +ki+1g/DMJfJJuskmsATMHwApEASlmvK14N05xaldnD6YzT6nvcM3nOLWOKdy5dOVCgR weqmJs6fUcUh46L712+j+AjrwdAU4oEJ9bYTF0C/WKUN0nj4/nnL2qRASYugOlljNA7l 3h1YcRSZ0eXcR0su+rxeWTFzIQzS84j17GFIidQvOCx6J6+QfVUKBBpsvf2XZ8/NvsNy ngXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5CtEYzn7kIwgucylcxTz9N8ey3nUOdntfUbQ88bxuCE=; b=sqJSM51iH/DgTbuWcz5VnvHbqidZ3Zy5XDFDUGf16QUptwqPmpJkrW0Uzzu8/WrVYc ikq5nSBh99ssDKKD+2QN0iPMYN2tDQ1Gzej1fmaV6dTcOqa3iNzraKUSv4vPzaZkop/P /dgqpBhOVvV2bij6SIm7AebidJ5rvoorkPRr+KnZLzsmeK6e+WhIf31lZaYzfPcymoE1 85t4+8g1jha8nodAtLHtQGrbMMnr/uy4hGAC7DuXd8DdlEouPGKLB/GINFKgt2yWLaX4 oH6BqR93kxKbqn1e30/jZkfvQ1mlxHQUXmYYjb31ETknpsGE50WiDLYoTX1rxTTxcZnb u5zw== X-Gm-Message-State: AOAM533iZyeF5e3OzGo/ArjJa8T9/Uy7xDvDodLOga0ZY0oOEP0ne/5l gAJ6pHbpdJ44cHPRdyomZyQmHQ== X-Google-Smtp-Source: ABdhPJwS38KMUVg12cbP/tOlpohlU/ohYYS3v7TQUu9ZHOsy/jn9DdfMfY39UoC8kf+BB65AOqhl0A== X-Received: by 2002:a9d:7003:: with SMTP id k3mr24903296otj.351.1618243278839; Mon, 12 Apr 2021 09:01:18 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id f8sm2730348otp.71.2021.04.12.09.01.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 09:01:18 -0700 (PDT) Date: Mon, 12 Apr 2021 11:01:16 -0500 From: Bjorn Andersson To: Arnd Bergmann List-Id: Cc: Geert Uytterhoeven , DTML , Rob Herring , Linus Walleij , Alexandre Belloni , Alexandre Torgue , Kevin Hilman , Linux Kernel Mailing List , Linux ARM , Tony Lindgren , Shawn Guo , Matthias Brugger , Nishanth Menon , Tero Kristo , SoC Team , Krzysztof Kozlowski , Gregory Clement , Florian Fainelli Subject: Re: New 'make dtbs_check W=1' warnings Message-ID: <20210412160116.GA904837@yoga> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 12 Apr 08:14 CDT 2021, Arnd Bergmann wrote: > On Mon, Apr 12, 2021 at 1:32 PM Geert Uytterhoeven wrote: > > On Thu, Apr 8, 2021 at 5:08 PM Arnd Bergmann wrote: > > > > > > > For this merge window, I don't think any of them are show-stoppers (Rob, let me > > > know if you disagree), but in the long run we may want to gradually enforce > > > a rule about not merging changes that introduce any new warnings, in order to > > > have a chance of cleaning up the existing ones. > > > > This may not be as simple as it sounds, as DT binding updates typically > > follow a different path than DTS(i) updates. DT bindings updates may be > > picked up by a subsystem maintainer, by Rob, or by the platform > > maintainer. > > I checked out the bindings from linux-next, which seems to have covered > most of these. Sometimes it pays off to be lazy and merge them after > everyone else. > > > For trivial updates (e.g. adding a compatible value, and sometimes > > extending a limit), a DTS(i) update may be accepted by the platform > > maintainer before the corresponding DT binding update. The latter may > > even be merged one or more kernel revisions later, especially when > > involving subsystems that are not traditionally rooted into platforms > > using DT. > > > > Of course we could mention any expected warning regressions in our pull > > requests for soc. > > Right, that would certainly help. Some maintainers send all binding > updates both to the driver maintainers and to the soc tree, along > with the other changes that only go into one tree. That is of course > also more work on your side, but it solves the problem entirely. > So the same binding patch is picked up both in the driver and soc tree? I was expecting that to cause (harmless) conflicts when things arrive in Linus' merge queue? Or are you saying people go the length to create immutable branches for each binding? I'm curious because it's fairly often that we introduce clocks, interconnects etc where the macros from the dt bindings includes aren't available for another release (so we use numerical constants and then go back and fix them up later). Regards, Bjorn > > > renesas/r8a774a1-beacon-rzg2m-kit.dt.yaml: csi2@feaa0000: ports: > > > 'port@0' is a required property > > > > [...] > > > > I've replied to these as a response to your PR reply, see > > https://lore.kernel.org/linux-renesas-soc/CAMuHMdWHLnXgBSjP7VKUdx-YNr9rSKFkE5Ge5q_tarU6HP9Lhw@mail.gmail.com/ > > Ok, thanks. > > Arnd