From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F9B7C433ED for ; Tue, 13 Apr 2021 09:25:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57C43613BA for ; Tue, 13 Apr 2021 09:25:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237403AbhDMJZW (ORCPT ); Tue, 13 Apr 2021 05:25:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229603AbhDMJZT (ORCPT ); Tue, 13 Apr 2021 05:25:19 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DF0FC061574 for ; Tue, 13 Apr 2021 02:25:00 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id h4so6667467wrt.12 for ; Tue, 13 Apr 2021 02:25:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OZorieMompIxVxiOSBvMLNyGFhhT3O9ebYrLxoCzZzw=; b=GqrGoa3RNiKS6efPceckOlU44wflpHz5xdRT6AdSCOOketGZcQ2saS6DOFpnEqzYCr BTQ4DVDv8vScsUH0P1Fx5kPhwFOVCmeJJTaSgo5mMt+PkGM6BFsfwLkqzBlGiTcYLQtl n3vJu/sInehd0DQ7fjJuLXvcBLmkKg4e7GoHMXdcWbFEqoxS/2O76KnnqU0mdgLlQ+7e 21WEcVplPuptUsIc6ndGPGD/5HFcSwzXYW4WHFgbxQ6prmorm2rJQl6rLEALcgNo0Ji4 InC7ZqLJnY/pwZvEHCHGW2CWw9oJ/7CzY82PfhgVsU+W5akwVNsFCLE9HF9kHFdQpmeJ ZvMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OZorieMompIxVxiOSBvMLNyGFhhT3O9ebYrLxoCzZzw=; b=ZeD1C3EfP+haunsUngzBHnscQfCpnFXomR8yK1E7zHVOdHJGQfcpOT0q5aeYkoCLLd P5UVTpTmK5e7UAuAoSxMSJetg5uplasmgQ2hY3KQyqHx0pd4MhW7Du3CLfPabqingZz3 nS2/S7P8uWkCUVf5RCMFdaO7R/E4C9y6zftwsCxaqZgAUCXbo9ttkLJ7mOjvQPZOW/hE iJBZHLWvf8HpVushvunTRIiIRF31P2jhnOMNvgwcRzoTesmf/OpaLYi9+NTh9YOzJua/ vPSjUIl1Ga5UyG1Jwe4yz4m8fuiLr77B3rNwrM2tP9uensxnSGclCO1B7Ohg/BzIeWOx W1CA== X-Gm-Message-State: AOAM5336pI4fK3j9D/zzK3l2Ymx2kx4Xdnqu4v7K37unSuI1bcztjK+w 2nkXHxc8s06BgUJD672Zlfk= X-Google-Smtp-Source: ABdhPJwukRLtu9M/6ocyZVdNi1uA2QaIjYM0UHLePhfg61Mk0ONZezguAbdxRev4hWRj6zQ2xOh0sQ== X-Received: by 2002:adf:fe86:: with SMTP id l6mr536230wrr.390.1618305898904; Tue, 13 Apr 2021 02:24:58 -0700 (PDT) Received: from agape.jhs ([5.171.81.136]) by smtp.gmail.com with ESMTPSA id h13sm1786917wmq.29.2021.04.13.02.24.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 02:24:58 -0700 (PDT) Date: Tue, 13 Apr 2021 11:24:56 +0200 From: Fabio Aiuto To: Greg KH Cc: joe@perches.com, julia.lawall@inria.fr, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: cocci script hints request Message-ID: <20210413092455.GB5477@agape.jhs> References: <20210413090400.GA5477@agape.jhs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 13, 2021 at 11:11:38AM +0200, Greg KH wrote: > On Tue, Apr 13, 2021 at 11:04:01AM +0200, Fabio Aiuto wrote: > > Hi, > > > > I would like to improve the following coccinelle script: > > > > @@ > > expression a, fmt; > > expression list var_args; > > @@ > > > > - DBG_871X_LEVEL(a, fmt, var_args); > > + printk(fmt, var_args); > > > > I would replace the DBG_871X_LEVEL macro with printk, > > No you really do not, you want to change that to a dev_*() call instead > depending on the "level" of the message. > > No "raw" printk() calls please, I will just reject them :) > > thanks, > > greg k-h but there are very few occurences of DBG_871X_LEVEL in module init functions: static int __init rtw_drv_entry(void) { int ret; DBG_871X_LEVEL(_drv_always_, "module init start\n"); dump_drv_version(RTW_DBGDUMP); #ifdef BTCOEXVERSION DBG_871X_LEVEL(_drv_always_, "rtl8723bs BT-Coex version = %s\n", BTCOEXVERSION); #endif /* BTCOEXVERSION */ sdio_drvpriv.drv_registered = true; ret = sdio_register_driver(&sdio_drvpriv.r871xs_drv); if (ret != 0) { sdio_drvpriv.drv_registered = false; rtw_ndev_notifier_unregister(); } DBG_871X_LEVEL(_drv_always_, "module init ret =%d\n", ret); return ret; } where I don't have a device available... shall I pass NULL to first argument? Another question: may I use netdev_dbg in case of rtl8723bs? thank you, fabio