* [PATCH] Bluetooth: btusb: fix memory leak
@ 2021-04-13 17:52 Muhammad Usama Anjum
2021-04-13 18:35 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Muhammad Usama Anjum @ 2021-04-13 17:52 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
mark-yw.chen, open list:BLUETOOTH DRIVERS, open list
Cc: musamaanjum, kernel-janitors, dan.carpenter, colin.king
If btusb_mtk_submit_wmt_recv_urb returns error, wc should be freed and
then error should be returned to prevent memory leak.
Addresses-Coverity: ("Prevent memory leak")
Fixes: 4cbb375e997d ("Bluetooth: btusb: Fixed too many in-token issue for Mediatek Chip.")
Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com>
---
drivers/bluetooth/btusb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 58ae824fb507..2c403188f586 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -3324,7 +3324,7 @@ static int btusb_mtk_hci_wmt_sync(struct hci_dev *hdev,
/* Submit control IN URB on demand to process the WMT event */
err = btusb_mtk_submit_wmt_recv_urb(hdev);
if (err < 0)
- return err;
+ goto err_free_wc;
/* The vendor specific WMT commands are all answered by a vendor
* specific event and will have the Command Status or Command
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Bluetooth: btusb: fix memory leak
2021-04-13 17:52 [PATCH] Bluetooth: btusb: fix memory leak Muhammad Usama Anjum
@ 2021-04-13 18:35 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2021-04-13 18:35 UTC (permalink / raw)
To: Muhammad Usama Anjum
Cc: Johan Hedberg, Luiz Augusto von Dentz, mark-yw.chen,
open list:BLUETOOTH DRIVERS, open list, kernel-janitors,
dan.carpenter, colin.king
Hi Muhammad,
> If btusb_mtk_submit_wmt_recv_urb returns error, wc should be freed and
> then error should be returned to prevent memory leak.
>
> Addresses-Coverity: ("Prevent memory leak")
> Fixes: 4cbb375e997d ("Bluetooth: btusb: Fixed too many in-token issue for Mediatek Chip.")
> Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com>
> ---
> drivers/bluetooth/btusb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-13 18:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-13 17:52 [PATCH] Bluetooth: btusb: fix memory leak Muhammad Usama Anjum
2021-04-13 18:35 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox