Re: [PATCH 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-block for vDPA

Jason Wang
2021-04-15T07:17:41Z

在 2021/4/15 下午2:41, Zhu Lingshan 写道:
>>>>
>>>> I think we've discussed this sometime in the past but what's the
>>>> reason for such whitelist consider there's already a get_features()
>>>> implemention?
>>>>
>>>> E.g Any reason to block VIRTIO_BLK_F_WRITE_ZEROS or
>>>> VIRTIO_F_RING_PACKED?
>>>>
>>>> Thanks
>>> The reason is some feature bits are supported in the device but not
>>> supported by the driver, e.g, for virtio-net, mq & cq implementation
>>> is not ready in the driver.
>>
>>
>> I understand the case of virtio-net but I wonder why we need this for
>> block where we don't vq cvq.
>>
>> Thanks
> This is still a subset of the feature bits read from hardware, I leave
> it here to code consistently, and indicate what we support clearly.
> Are you suggesting remove this feature bits list and just use what we
> read from hardware?
>
> Thansk

Yes, please do that.

The whiltelist doesn't help in this case I think.

Thanks