Re: [PATCH 4/7] virtio_pci_modern: hide vp_modern_get_queue_notify_off()

Eli Cohen
2021-04-21T07:46:03Z

On Thu, Apr 15, 2021 at 03:31:44AM -0400, Jason Wang wrote:
> All users (both virtio-pci library and vp_vdpa driver) has been
> switched to use vp_modern_map_vq_notify(). So there's no need to
> export the low level helper of vp_modern_get_queue_notify_off().
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>

Reviewed-by: Eli Cohen <elic@nvidia.com>

> ---
> drivers/virtio/virtio_pci_modern_dev.c | 5 ++---
> include/linux/virtio_pci_modern.h | 2 --
> 2 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/virtio/virtio_pci_modern_dev.c b/drivers/virtio/virtio_pci_modern_dev.c
> index 28cb5847fafa..5a657e56b46d 100644
> --- a/drivers/virtio/virtio_pci_modern_dev.c
> +++ b/drivers/virtio/virtio_pci_modern_dev.c
> @@ -584,14 +584,13 @@ EXPORT_SYMBOL_GPL(vp_modern_get_num_queues);
> *
> * Returns the notification offset for a virtqueue
> */
> -u16 vp_modern_get_queue_notify_off(struct virtio_pci_modern_device *mdev,
> - u16 index)
> +static u16 vp_modern_get_queue_notify_off(struct virtio_pci_modern_device *mdev,
> + u16 index)
> {
> vp_iowrite16(index, &mdev->common->queue_select);
>
> return vp_ioread16(&mdev->common->queue_notify_off);
> }
> -EXPORT_SYMBOL_GPL(vp_modern_get_queue_notify_off);
>
> /*
> * vp_modern_map_vq_notify - map notification area for a
> diff --git a/include/linux/virtio_pci_modern.h b/include/linux/virtio_pci_modern.h
> index 1b95d39b00fc..179a2fb4bf37 100644
> --- a/include/linux/virtio_pci_modern.h
> +++ b/include/linux/virtio_pci_modern.h
> @@ -99,8 +99,6 @@ void vp_modern_set_queue_size(struct virtio_pci_modern_device *mdev,
> u16 vp_modern_get_queue_size(struct virtio_pci_modern_device *mdev,
> u16 idx);
> u16 vp_modern_get_num_queues(struct virtio_pci_modern_device *mdev);
> -u16 vp_modern_get_queue_notify_off(struct virtio_pci_modern_device *mdev,
> - u16 idx);
> void __iomem *vp_modern_map_capability(struct virtio_pci_modern_device *mdev, int off,
> size_t minlen,
> u32 align,
> --
> 2.18.1
>