From: Willy Tarreau <w@1wt.eu>
To: Colin King <colin.king@canonical.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
Denis Efremov <efremov@linux.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] floppy: remove redundant assignment to variable st
Date: Thu, 15 Apr 2021 15:21:45 +0200 [thread overview]
Message-ID: <20210415132145.GD2791@1wt.eu> (raw)
In-Reply-To: <20210415130020.1959951-1-colin.king@canonical.com>
On Thu, Apr 15, 2021 at 02:00:20PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable st is being assigned a value that is never read and
> it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Indeed you're right.
Acked-by: Willy Tarreau <w@1wt.eu>
Willy
next prev parent reply other threads:[~2021-04-15 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 13:00 [PATCH] floppy: remove redundant assignment to variable st Colin King
2021-04-15 13:21 ` Willy Tarreau [this message]
2021-04-16 7:34 ` Denis Efremov
2021-04-16 12:29 ` Denis Efremov
2021-04-16 12:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415132145.GD2791@1wt.eu \
--to=w@1wt.eu \
--cc=bp@alien8.de \
--cc=colin.king@canonical.com \
--cc=efremov@linux.com \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox