From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: [for-next][PATCH 3/7] tracing: Add "last_func_repeats" to struct trace_array
Date: Fri, 16 Apr 2021 13:26:15 -0400 [thread overview]
Message-ID: <20210416172656.610535799@goodmis.org> (raw)
In-Reply-To: 20210416172612.086725495@goodmis.org
From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
The field is used to keep track of the consecutive (on the same CPU) calls
of a single function. This information is needed in order to consolidate
the function tracing record in the cases when a single function is called
number of times.
Link: https://lkml.kernel.org/r/20210415181854.147448-4-y.karadz@gmail.com
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
kernel/trace/trace.c | 1 +
kernel/trace/trace.h | 12 ++++++++++++
2 files changed, 13 insertions(+)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 507a30bf26e4..82833be07c1e 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -9104,6 +9104,7 @@ static int __remove_instance(struct trace_array *tr)
ftrace_clear_pids(tr);
ftrace_destroy_function_files(tr);
tracefs_remove(tr->dir);
+ free_percpu(tr->last_func_repeats);
free_trace_buffers(tr);
for (i = 0; i < tr->nr_topts; i++) {
diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
index 6a5b4c2a0fa7..a4f1b66049fd 100644
--- a/kernel/trace/trace.h
+++ b/kernel/trace/trace.h
@@ -262,6 +262,17 @@ struct cond_snapshot {
cond_update_fn_t update;
};
+/*
+ * struct trace_func_repeats - used to keep track of the consecutive
+ * (on the same CPU) calls of a single function.
+ */
+struct trace_func_repeats {
+ unsigned long ip;
+ unsigned long parent_ip;
+ unsigned long count;
+ u64 ts_last_call;
+};
+
/*
* The trace array - an array of per-CPU trace arrays. This is the
* highest level data structure that individual tracers deal with.
@@ -358,6 +369,7 @@ struct trace_array {
#ifdef CONFIG_TRACER_SNAPSHOT
struct cond_snapshot *cond_snapshot;
#endif
+ struct trace_func_repeats __percpu *last_func_repeats;
};
enum {
--
2.30.1
next prev parent reply other threads:[~2021-04-16 17:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 17:26 [for-next][PATCH 0/7] tracing: Add func_no_repeats option Steven Rostedt
2021-04-16 17:26 ` [for-next][PATCH 1/7] tracing: Define static void trace_print_time() Steven Rostedt
2021-04-16 17:26 ` [for-next][PATCH 2/7] tracing: Define new ftrace event "func_repeats" Steven Rostedt
2021-04-16 17:26 ` Steven Rostedt [this message]
2021-04-16 17:26 ` [for-next][PATCH 4/7] tracing: Add method for recording "func_repeats" events Steven Rostedt
2021-04-16 17:26 ` [for-next][PATCH 5/7] tracing: Unify the logic for function tracing options Steven Rostedt
2021-04-16 17:26 ` [for-next][PATCH 6/7] tracing: Add "func_no_repeats" option for function tracing Steven Rostedt
2021-04-16 17:26 ` [for-next][PATCH 7/7] ftrace: Reuse the output of the function tracer for func_repeats Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416172656.610535799@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox