From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECAC3C43470 for ; Mon, 19 Apr 2021 20:47:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2F1961104 for ; Mon, 19 Apr 2021 20:47:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243071AbhDSUsT (ORCPT ); Mon, 19 Apr 2021 16:48:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:54660 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242612AbhDSUph (ORCPT ); Mon, 19 Apr 2021 16:45:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8187E613AB; Mon, 19 Apr 2021 20:44:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618865098; bh=bULdcyXrCo7E1DtG+Eqo2f5vW2vgbbzbBhwmacpqDhk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oZ57HVBuvPmDaAcEsZ4RIa4OFoD+tqWVjx78MaVZIfk21UEDTBuOJcSxVwYv0wQAt 6CMjV6zGCwH681R5iBoG0dZPT22Lmnq3SDqf4TNk/LFpte0/ToYPLz1UjoT7S7ppli JSeFS9EdqP1BTtNnkf0m38gMFhQr2A8eOAIgmHRS1jQYGF3Rpgw0UmIBMJf58jZvAq VhjVvrUZrvDzQakKQwhn6bR87Svj2rnoWainHycL2gBkw8J/h6EH56mJ+9Wf/IGx4j lJHxxojLhQN4HAaQ2wDd2xKWOjQR5yRSg0PPM5/fxRHk/KvHxaggz+WeMpLVJoTgkI lw7itv3UzpHXA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jia-Ju Bai , TOTE Robot , Jiri Kosina , Sasha Levin , linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 02/14] HID: alps: fix error return code in alps_input_configured() Date: Mon, 19 Apr 2021 16:44:42 -0400 Message-Id: <20210419204454.6601-2-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210419204454.6601-1-sashal@kernel.org> References: <20210419204454.6601-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia-Ju Bai [ Upstream commit fa8ba6e5dc0e78e409e503ddcfceef5dd96527f4 ] When input_register_device() fails, no error return code is assigned. To fix this bug, ret is assigned with -ENOENT as error return code. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-alps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c index d33f5abc8f64..2477b2a3f7c3 100644 --- a/drivers/hid/hid-alps.c +++ b/drivers/hid/hid-alps.c @@ -762,6 +762,7 @@ static int alps_input_configured(struct hid_device *hdev, struct hid_input *hi) if (input_register_device(data->input2)) { input_free_device(input2); + ret = -ENOENT; goto exit; } } -- 2.30.2