Re: [PATCH v1 2/3] binfmt: remove in-tree usage of MAP_EXECUTABLE

David Hildenbrand
2021-05-12T13:12:36Z

On 21.04.21 11:34, David Hildenbrand wrote:
> Ever since commit e9714acf8c43 ("mm: kill vma flag VM_EXECUTABLE and
> mm->num_exe_file_vmas"), VM_EXECUTABLE is gone and MAP_EXECUTABLE is
> essentially completely ignored. Let's remove all usage of
> MAP_EXECUTABLE.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>

[...]

> +++ b/fs/binfmt_aout.c
> @@ -222,7 +222,7 @@ static int load_aout_binary(struct linux_binprm * bprm)
>
> error = vm_mmap(bprm->file, N_TXTADDR(ex), ex.a_text,
> PROT_READ | PROT_EXEC,
> - MAP_FIXED | MAP_PRIVATE | MAP_DENYWRITE | MAP_EXECUTABLE,
> + MAP_FIXED | MAP_PRIVATE | MAP_DENYWRITE;

As reported by kernel test robot, this line should end with a ","

> fd_offset);
>
> if (error != N_TXTADDR(ex))
> @@ -230,7 +230,7 @@ static int load_aout_binary(struct linux_binprm * bprm)
>
> error = vm_mmap(bprm->file, N_DATADDR(ex), ex.a_data,
> PROT_READ | PROT_WRITE | PROT_EXEC,
> - MAP_FIXED | MAP_PRIVATE | MAP_DENYWRITE | MAP_EXECUTABLE,
> + MAP_FIXED | MAP_PRIVATE | MAP_DENYWRITE;
> fd_offset + ex.a_text);

dito

@Andrew, I think this resides your tree. Can you fix that up or shall I
resend the series, or only this individual patch?

--
Thanks,

David / dhildenb