From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78962C433B4 for ; Wed, 21 Apr 2021 13:19:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C81B61456 for ; Wed, 21 Apr 2021 13:19:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241394AbhDUNUD (ORCPT ); Wed, 21 Apr 2021 09:20:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:53968 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239158AbhDUNKo (ORCPT ); Wed, 21 Apr 2021 09:10:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3D7746148E; Wed, 21 Apr 2021 13:10:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619010610; bh=kjXAUv99G2avn802/hzqZ5IanH+hhReejDiK5KrFqTY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fVPG7+ngo1U4LEcO4kzo9Dnyc0yaDwBxqM3dSj+/KYFQ1y+YATLdK/4d6Bvbu/Fom Jj303ldpFruo3/bNOf39quq3EepcK5Pt2Tuu6XKddCUFpeBHEQpn6+lTagvMfkk5qq tEr5D0RvXHAHDfJ/Oc/p0Z0bG0dD6TxU2OehFE4c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Wenwen Wang , "David S . Miller" Subject: [PATCH 190/190] Revert "ethtool: fix a potential missing-check bug" Date: Wed, 21 Apr 2021 15:01:05 +0200 Message-Id: <20210421130105.1226686-191-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210421130105.1226686-1-gregkh@linuxfoundation.org> References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit d656fe49e33df48ee6bc19e871f5862f49895c9e. Commits from @umn.edu addresses have been found to be submitted in "bad faith" to try to test the kernel community's ability to review "known malicious" changes. The result of these submissions can be found in a paper published at the 42nd IEEE Symposium on Security and Privacy entitled, "Open Source Insecurity: Stealthily Introducing Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University of Minnesota) and Kangjie Lu (University of Minnesota). Because of this, all submissions from this group must be reverted from the kernel tree and will need to be re-reviewed again to determine if they actually are a valid fix. Until that work is complete, remove this change to ensure that no problems are being introduced into the codebase. Cc: Wenwen Wang Cc: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ethtool/ioctl.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c index 807bc9465add..542f2428014c 100644 --- a/net/ethtool/ioctl.c +++ b/net/ethtool/ioctl.c @@ -869,11 +869,6 @@ static noinline_for_stack int ethtool_get_rxnfc(struct net_device *dev, info_size = sizeof(info); if (copy_from_user(&info, useraddr, info_size)) return -EFAULT; - /* Since malicious users may modify the original data, - * we need to check whether FLOW_RSS is still requested. - */ - if (!(info.flow_type & FLOW_RSS)) - return -EINVAL; } if (info.cmd == ETHTOOL_GRXCLSRLALL) { -- 2.31.1