From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2B30C433B4 for ; Wed, 21 Apr 2021 13:04:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 679136144C for ; Wed, 21 Apr 2021 13:04:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240572AbhDUNEf (ORCPT ); Wed, 21 Apr 2021 09:04:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:43838 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240602AbhDUNEB (ORCPT ); Wed, 21 Apr 2021 09:04:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 95AB061457; Wed, 21 Apr 2021 13:03:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619010208; bh=YBE/vMX5lB1YetSQlbQxSdFshyJMtgbig4qxvkfZ9CE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vM7c5GT1sMV0bfdifREEtPdGNPtaxaUkovIpRmlXTdssDrN/Lantdefbd0NrRaEdJ 4GrQkwssIJRWQgiIYFwEK4WDGiMAnc2lPkQBOGiiSKsQ/CSlxhHwwxuV0MjQq/E/io 90i5uDnnkDXpJeog3JHW/yfWmQ5VxtL3nXKhyqNU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@kernel.org, Qiushi Wu , Sebastian Reichel Subject: [PATCH 051/190] Revert "power: supply: core: fix memory leak in HWMON error path" Date: Wed, 21 Apr 2021 14:58:46 +0200 Message-Id: <20210421130105.1226686-52-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210421130105.1226686-1-gregkh@linuxfoundation.org> References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit 1d7a7128a2e9e1f137c99b0a44e94d70a77343e3. Commits from @umn.edu addresses have been found to be submitted in "bad faith" to try to test the kernel community's ability to review "known malicious" changes. The result of these submissions can be found in a paper published at the 42nd IEEE Symposium on Security and Privacy entitled, "Open Source Insecurity: Stealthily Introducing Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University of Minnesota) and Kangjie Lu (University of Minnesota). Because of this, all submissions from this group must be reverted from the kernel tree and will need to be re-reviewed again to determine if they actually are a valid fix. Until that work is complete, remove this change to ensure that no problems are being introduced into the codebase. Cc: stable@kernel.org Cc: Qiushi Wu Cc: Sebastian Reichel Signed-off-by: Greg Kroah-Hartman --- drivers/power/supply/power_supply_hwmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/power_supply_hwmon.c b/drivers/power/supply/power_supply_hwmon.c index bffe6d84c429..62ca29e0d47a 100644 --- a/drivers/power/supply/power_supply_hwmon.c +++ b/drivers/power/supply/power_supply_hwmon.c @@ -356,7 +356,7 @@ int power_supply_add_hwmon_sysfs(struct power_supply *psy) goto error; } - ret = devm_add_action_or_reset(dev, power_supply_hwmon_bitmap_free, + ret = devm_add_action(dev, power_supply_hwmon_bitmap_free, psyhw->props); if (ret) goto error; -- 2.31.1