Re: [PATCH 4/4] dt-bindings: arm: keystone: Convert ti,sci to json schema

Nishanth Menon
2021-04-22T14:17:54Z

On 17:40-20210421, Rob Herring wrote:

[..]

> > +allOf:
> > + - $ref: /schemas/mbox/mbox-consumer.yaml#
>
> Drop.
>

OK.

> > + reg-names:
> > + description: |
> > + Specifies the debug messages memory mapped region that is optionally
> > + made available from TI-SCI controller.
> > + - const: debug_messages
>
> Drop the '-' and fix the indent so it's an actual schema.

OK.

[..]
> > +patternProperties:
> > + # All other properties should be a power, clock or reset controller
> > + "^(power-controller|clock-controller|reset-controller)$":
> > + type: object
> > + oneOf:
> > + - $ref: /schemas/soc/ti/sci-pm-domain.yaml#
> > + - $ref: /schemas/clock/ti,sci-clk.yaml#
> > + - $ref: /schemas/reset/ti,sci-reset.yaml#
>
> I'd prefer you separate these with a property for each node.

Hmm... I am not sure I completely understand your comment here.
I assume we dont want to duplicate each of those node yamls, so,
did you mean something like:

ti,sci-clk as a bool property in the tisci node and if present, then
expect the node ti,sci-clk node?

Can you give me a hint of similar yaml usage elsewhere that I can refer
to?

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D