Re: [PATCH 027/190] Revert "ASoC: rockchip: Fix a reference count leak."

Greg Kroah-Hartman
2021-04-27T16:27:51Z

On Wed, Apr 21, 2021 at 02:58:22PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit f141a422159a199f4c8dedb7e0df55b3b2cf16cd.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes. The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix. Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
>
> Cc: Qiushi Wu <wu000273@umn.edu>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: https
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> sound/soc/rockchip/rockchip_pdm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/rockchip/rockchip_pdm.c b/sound/soc/rockchip/rockchip_pdm.c
> index 9295d648624e..c52e1dbf6dbe 100644
> --- a/sound/soc/rockchip/rockchip_pdm.c
> +++ b/sound/soc/rockchip/rockchip_pdm.c
> @@ -590,10 +590,8 @@ static int rockchip_pdm_resume(struct device *dev)
> int ret;
>
> ret = pm_runtime_get_sync(dev);
> - if (ret < 0) {
> - pm_runtime_put(dev);
> + if (ret < 0)
> return ret;
> - }
>
> ret = regcache_sync(pdm->regmap);
>
> --
> 2.31.1
>

Looks correct, dropping.

greg k-h