Re: [PATCH 128/190] Revert "net: strparser: fix a missing check for create_singlethread_workqueue"

Greg Kroah-Hartman
2021-04-28T05:39:58Z

On Wed, Apr 21, 2021 at 03:00:03PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit 228cd2dba27cee9956c1af97e6445be056881e41.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes. The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix. Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
>
> Cc: Kangjie Lu <kjlu@umn.edu>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> net/strparser/strparser.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/strparser/strparser.c b/net/strparser/strparser.c
> index b3815c1e8f2e..efce4ddaa320 100644
> --- a/net/strparser/strparser.c
> +++ b/net/strparser/strparser.c
> @@ -542,8 +542,6 @@ EXPORT_SYMBOL_GPL(strp_check_rcv);
> static int __init strp_dev_init(void)
> {
> strp_wq = create_singlethread_workqueue("kstrp");
> - if (unlikely(!strp_wq))
> - return -ENOMEM;
>
> return 0;
> }
> --
> 2.31.1
>

In the original commit "unlikely" should not have been used as it is not
needed at all (the compiler and CPU already know this), but the commit
is correct so I'll drop this revert.

greg k-h