Re: [PATCH 089/190] Revert "PCI: endpoint: Fix a potential NULL pointer dereference"

Lorenzo Pieralisi
2021-04-22T09:31:22Z

On Wed, Apr 21, 2021 at 02:59:24PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit 507b820009a457afa78202da337bcb56791fbb12.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes. The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix. Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
>
> Cc: Kangjie Lu <kjlu@umn.edu>
> Cc: commit log and code update]

Hi Greg,

first off, thank you for doing this.

This Cc should be fixed up if we go ahead with the revert (I can
take the revert via the PCI tree and fix it up myself).

I totally understand your concern (and the nuisance it is causing), the
commit we are reverting looked and looks legit - just let me know
how it is best to handle this please.

Thanks,
Lorenzo

> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/pci/endpoint/functions/pci-epf-test.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
> index c0ac4e9cbe72..39dd394284a5 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -915,11 +915,6 @@ static int __init pci_epf_test_init(void)
>
> kpcitest_workqueue = alloc_workqueue("kpcitest",
> WQ_MEM_RECLAIM | WQ_HIGHPRI, 0);
> - if (!kpcitest_workqueue) {
> - pr_err("Failed to allocate the kpcitest work queue\n");
> - return -ENOMEM;
> - }
> -
> ret = pci_epf_register_driver(&test_driver);
> if (ret) {
> pr_err("Failed to register pci epf test driver --> %d\n", ret);
> --
> 2.31.1
>