Re: [PATCH 089/190] Revert "PCI: endpoint: Fix a potential NULL pointer dereference"

Greg Kroah-Hartman
2021-04-26T16:59:25Z

On Thu, Apr 22, 2021 at 11:40:21AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Apr 22, 2021 at 10:31:11AM +0100, Lorenzo Pieralisi wrote:
> > On Wed, Apr 21, 2021 at 02:59:24PM +0200, Greg Kroah-Hartman wrote:
> > > This reverts commit 507b820009a457afa78202da337bcb56791fbb12.
> > >
> > > Commits from @umn.edu addresses have been found to be submitted in "bad
> > > faith" to try to test the kernel community's ability to review "known
> > > malicious" changes. The result of these submissions can be found in a
> > > paper published at the 42nd IEEE Symposium on Security and Privacy
> > > entitled, "Open Source Insecurity: Stealthily Introducing
> > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > > of Minnesota) and Kangjie Lu (University of Minnesota).
> > >
> > > Because of this, all submissions from this group must be reverted from
> > > the kernel tree and will need to be re-reviewed again to determine if
> > > they actually are a valid fix. Until that work is complete, remove this
> > > change to ensure that no problems are being introduced into the
> > > codebase.
> > >
> > > Cc: Kangjie Lu <kjlu@umn.edu>
> > > Cc: commit log and code update]
> >
> > Hi Greg,
> >
> > first off, thank you for doing this.
> >
> > This Cc should be fixed up if we go ahead with the revert (I can
> > take the revert via the PCI tree and fix it up myself).
> >
> > I totally understand your concern (and the nuisance it is causing), the
> > commit we are reverting looked and looks legit - just let me know
> > how it is best to handle this please.
>
> I'll fix up all improper Cc: lines, that was my dumb script trying to
> catch who was on the reverted patch, when I apply these.
>
> I can take this through my tree, but as you said, if the original commit
> here really is fine, that's great, I'll drop this.

Now dropped from my tree.

greg k-