Re: [PATCH 139/190] Revert "isdn: mISDNinfineon: fix potential NULL pointer dereference"

Greg Kroah-Hartman
2021-04-27T14:31:51Z

On Wed, Apr 21, 2021 at 03:00:14PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit d721fe99f6ada070ae8fc0ec3e01ce5a42def0d9.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes. The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix. Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
>
> Cc: Kangjie Lu <kjlu@umn.edu>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/isdn/hardware/mISDN/mISDNinfineon.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/isdn/hardware/mISDN/mISDNinfineon.c b/drivers/isdn/hardware/mISDN/mISDNinfineon.c
> index a16c7a2a7f3d..fa9c491f9c38 100644
> --- a/drivers/isdn/hardware/mISDN/mISDNinfineon.c
> +++ b/drivers/isdn/hardware/mISDN/mISDNinfineon.c
> @@ -697,11 +697,8 @@ setup_io(struct inf_hw *hw)
> (ulong)hw->addr.start, (ulong)hw->addr.size);
> return err;
> }
> - if (hw->ci->addr_mode == AM_MEMIO) {
> + if (hw->ci->addr_mode == AM_MEMIO)
> hw->addr.p = ioremap(hw->addr.start, hw->addr.size);
> - if (unlikely(!hw->addr.p))
> - return -ENOMEM;
> - }
> hw->addr.mode = hw->ci->addr_mode;
> if (debug & DEBUG_HW)
> pr_notice("%s: IO addr %lx (%lu bytes) mode%d\n",
> --
> 2.31.1
>

This commit is wrong, so I will keep the revert. It should never have
used "unlikely()" and if it ever does trigger, resources are left
grabbed.

Given there are no users for this code around, I'll just revert this and
leave it "as is" as the odds that ioremap() will ever fail here is
horrendiously low.

thanks,

greg k-h