Re: [PATCH 138/190] Revert "net: liquidio: fix a NULL pointer dereference"

Greg Kroah-Hartman
2021-04-27T17:31:15Z

On Wed, Apr 21, 2021 at 03:00:13PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit fe543b2f174f34a7a751aa08b334fe6b105c4569.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes. The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix. Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
>
> Cc: Kangjie Lu <kjlu@umn.edu>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/net/ethernet/cavium/liquidio/lio_main.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c
> index 7c5af4beedc6..6fa570068648 100644
> --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c
> +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c
> @@ -1166,11 +1166,6 @@ static void send_rx_ctrl_cmd(struct lio *lio, int start_stop)
> sc = (struct octeon_soft_command *)
> octeon_alloc_soft_command(oct, OCTNET_CMD_SIZE,
> 16, 0);
> - if (!sc) {
> - netif_info(lio, rx_err, lio->netdev,
> - "Failed to allocate octeon_soft_command\n");
> - return;
> - }
>
> ncmd = (union octnet_cmd *)sc->virtdptr;
>
> --
> 2.31.1
>

While this does keep the immediate "NULL dereference" from happening, it
does not properly propagate the error back to the callers, AND it does
not fix this same identical issue in the
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c for some reason. I
will revert this and fix up both files properly in a later on patch.

thanks,

greg k-h