Re: [PATCH 042/190] Revert "ASoC: fix incomplete error-handling in img_i2s_in_probe."

Greg Kroah-Hartman
2021-04-27T16:29:53Z

On Wed, Apr 21, 2021 at 02:58:37PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit 25bf943e4e7b47282bd86ae7d39e039217ebb007.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes. The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix. Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
>
> Cc: Qiushi Wu <wu000273@umn.edu>
> Cc: https
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> sound/soc/img/img-i2s-in.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/img/img-i2s-in.c b/sound/soc/img/img-i2s-in.c
> index e30b66b94bf6..a495d1050d49 100644
> --- a/sound/soc/img/img-i2s-in.c
> +++ b/sound/soc/img/img-i2s-in.c
> @@ -482,7 +482,6 @@ static int img_i2s_in_probe(struct platform_device *pdev)
> if (IS_ERR(rst)) {
> if (PTR_ERR(rst) == -EPROBE_DEFER) {
> ret = -EPROBE_DEFER;
> - pm_runtime_put(&pdev->dev);
> goto err_suspend;
> }
>
> --
> 2.31.1
>

Looks correct, dropping.

greg k-h