Re: [PATCH 125/190] Revert "net: tipc: fix a missing check of nla_nest_start"

Greg Kroah-Hartman
2021-04-28T05:39:05Z

On Wed, Apr 21, 2021 at 03:00:00PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit 4589e28db46ee4961edfd794c5bb43887d38c8e5.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes. The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix. Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
>
> Cc: Kangjie Lu <kjlu@umn.edu>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> net/tipc/group.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/net/tipc/group.c b/net/tipc/group.c
> index 3e137d8c9d2f..d18d497af4de 100644
> --- a/net/tipc/group.c
> +++ b/net/tipc/group.c
> @@ -927,9 +927,6 @@ int tipc_group_fill_sock_diag(struct tipc_group *grp, struct sk_buff *skb)
> {
> struct nlattr *group = nla_nest_start_noflag(skb, TIPC_NLA_SOCK_GROUP);
>
> - if (!group)
> - return -EMSGSIZE;
> -
> if (nla_put_u32(skb, TIPC_NLA_SOCK_GROUP_ID,
> grp->type) ||
> nla_put_u32(skb, TIPC_NLA_SOCK_GROUP_INSTANCE,
> --
> 2.31.1
>

The original commit here was fine, I'll drop this revert.

greg k-h