Re: [PATCH 106/190] Revert "tty: ipwireless: fix missing checks for ioremap"

David Sterba
2021-04-21T16:01:27Z

On Wed, Apr 21, 2021 at 02:59:41PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit 1bbb1c318cd8a3a39e8c3e2e83d5e90542d6c3e3.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes. The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix. Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.

I've reviewed the patch at the time and now again with fresh eyes, but
it's IMO a valid fix that would have to be done the same way after
revert.