Re: [PATCH 000/190] Revertion of all of the umn.edu commits

Greg Kroah-Hartman
2021-04-27T16:44:11Z

On Wed, Apr 21, 2021 at 07:35:44PM +0200, Daniel Vetter wrote:
> On Wed, Apr 21, 2021 at 3:01 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > I have been meaning to do this for a while, but recent events have
> > finally forced me to do so.
> >
> > Commits from @umn.edu addresses have been found to be submitted in "bad
> > faith" to try to test the kernel community's ability to review "known
> > malicious" changes. The result of these submissions can be found in a
> > paper published at the 42nd IEEE Symposium on Security and Privacy
> > entitled, "Open Source Insecurity: Stealthily Introducing
> > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > of Minnesota) and Kangjie Lu (University of Minnesota).
> >
> > Because of this, all submissions from this group must be reverted from
> > the kernel tree and will need to be re-reviewed again to determine if
> > they actually are a valid fix. Until that work is complete, remove this
> > change to ensure that no problems are being introduced into the
> > codebase.
> >
> > This patchset has the "easy" reverts, there are 68 remaining ones that
> > need to be manually reviewed. Some of them are not able to be reverted
> > as they already have been reverted, or fixed up with follow-on patches
> > as they were determined to be invalid. Proof that these submissions
> > were almost universally wrong.
>
> Will you take care of these remaining ones in subsequent patches too?

Yes I will.

> > I will be working with some other kernel developers to determine if any
> > of these reverts were actually valid changes, were actually valid, and
> > if so, will resubmit them properly later. For now, it's better to be
> > safe.
> >
> > I'll take this through my tree, so no need for any maintainer to worry
> > about this, but they should be aware that future submissions from anyone
> > with a umn.edu address should be by default-rejected unless otherwise
> > determined to actually be a valid fix (i.e. they provide proof and you
> > can verify it, but really, why waste your time doing that extra work?)
> >
> > thanks,
> >
> > greg k-h
> >
> > Greg Kroah-Hartman (190):
> > Revert "net/rds: Avoid potential use after free in
> > rds_send_remove_from_sock"
> > Revert "media: st-delta: Fix reference count leak in delta_run_work"
> > Revert "media: sti: Fix reference count leaks"
> > Revert "media: exynos4-is: Fix several reference count leaks due to
> > pm_runtime_get_sync"
> > Revert "media: exynos4-is: Fix a reference count leak due to
> > pm_runtime_get_sync"
> > Revert "media: exynos4-is: Fix a reference count leak"
> > Revert "media: ti-vpe: Fix a missing check and reference count leak"
> > Revert "media: stm32-dcmi: Fix a reference count leak"
> > Revert "media: s5p-mfc: Fix a reference count leak"
> > Revert "media: camss: Fix a reference count leak."
> > Revert "media: platform: fcp: Fix a reference count leak."
> > Revert "media: rockchip/rga: Fix a reference count leak."
> > Revert "media: rcar-vin: Fix a reference count leak."
> > Revert "media: rcar-vin: Fix a reference count leak."
> > Revert "firmware: Fix a reference count leak."
> > Revert "drm/nouveau: fix reference count leak in
> > nouveau_debugfs_strap_peek"
> > Revert "drm/nouveau: fix reference count leak in
> > nv50_disp_atomic_commit"
> > Revert "drm/nouveau: fix multiple instances of reference count leaks"
> > Revert "drm/nouveau/drm/noveau: fix reference count leak in
> > nouveau_fbcon_open"
> > Revert "PCI: Fix pci_create_slot() reference count leak"
> > Revert "omapfb: fix multiple reference count leaks due to
> > pm_runtime_get_sync"
> > Revert "drm/radeon: Fix reference count leaks caused by
> > pm_runtime_get_sync"
> > Revert "drm/radeon: fix multiple reference count leak"
> > Revert "drm/amdkfd: Fix reference count leaks."
>
> I didn't review these carefully, but from a quick look they all seem
> rather inconsequental. Either error paths that are very unlikely, or
> drivers which are very dead (looking at the entire list, not just what
> you reverted here).
>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Thanks for the quick review, I'm now going over them all again to see if
they are valid or not, some of the pm reference count stuff all looks
correct. Others not at all.

> Also adding drm maintainers/lists, those aren't all on your cc it
> seems. I will also forward this to fd.o sitewranglers as abuse of our
> infrastructure, it's for community collaboration, not for inflicting
> experiments on unconsenting subjects.

Much appreciated.

greg k-h