Re: [PATCH 060/190] Revert "staging: kpc2000: remove unnecessary assertions in kpc_dma_transfer"

Greg Kroah-Hartman
2021-04-27T11:54:52Z

On Wed, Apr 21, 2021 at 02:58:55PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit d7a336d67ab5443a0ef14b8335d139e855e8a682.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes. The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix. Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
>
> Cc: Aditya Pakki <pakki001@umn.edu>
> Cc: https
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/staging/kpc2000/kpc_dma/fileops.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c b/drivers/staging/kpc2000/kpc_dma/fileops.c
> index 10dcd6646b01..7fdad86044ca 100644
> --- a/drivers/staging/kpc2000/kpc_dma/fileops.c
> +++ b/drivers/staging/kpc2000/kpc_dma/fileops.c
> @@ -49,7 +49,9 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
> u64 dma_addr;
> u64 user_ctl;
>
> + BUG_ON(priv == NULL);
> ldev = priv->ldev;
> + BUG_ON(ldev == NULL);
>
> acd = kzalloc(sizeof(*acd), GFP_KERNEL);
> if (!acd) {
> --
> 2.31.1

This one looks fine, I'm dropping it.

greg k-h