Re: [PATCH 028/190] Revert "RDMA/rvt: Fix potential memory leak caused by rvt_alloc_rq"

Greg Kroah-Hartman
2021-04-27T14:22:23Z

On Wed, Apr 21, 2021 at 11:11:05AM -0300, Jason Gunthorpe wrote:
> On Wed, Apr 21, 2021 at 02:58:23PM +0200, Greg Kroah-Hartman wrote:
> > This reverts commit 90a239ee25fa3a483facec3de7c144361a3d3a51.
> >
> > Commits from @umn.edu addresses have been found to be submitted in "bad
> > faith" to try to test the kernel community's ability to review "known
> > malicious" changes. The result of these submissions can be found in a
> > paper published at the 42nd IEEE Symposium on Security and Privacy
> > entitled, "Open Source Insecurity: Stealthily Introducing
> > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > of Minnesota) and Kangjie Lu (University of Minnesota).
> >
> > Because of this, all submissions from this group must be reverted from
> > the kernel tree and will need to be re-reviewed again to determine if
> > they actually are a valid fix. Until that work is complete, remove this
> > change to ensure that no problems are being introduced into the
> > codebase.
> >
> > Cc: https
> > Cc: Aditya Pakki <pakki001@umn.edu>
> > Cc: Dennis Dalessandro <dennis.dalessandro@intel.com>
> > Cc: Jason Gunthorpe <jgg@mellanox.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> > drivers/infiniband/sw/rdmavt/qp.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
>
> While I don't see anything obviously wrong here it is tricky enough
> that I would revert it unless Dennis says otherwise.

Thanks for the review, now dropped.

greg k-h