Re: [PATCH 154/190] Revert "ath6kl: return error code in ath6kl_wmi_set_roam_lrssi_cmd()"

Greg Kroah-Hartman
2021-04-27T17:48:37Z

On Wed, Apr 21, 2021 at 03:00:29PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit fc6a6521556c8250e356ddc6a3f2391aa62dc976.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes. The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix. Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
>
> Cc: Kangjie Lu <kjlu@umn.edu>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/net/wireless/ath/ath6kl/wmi.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/wmi.c b/drivers/net/wireless/ath/ath6kl/wmi.c
> index b137e7f34397..aca9732ec1ee 100644
> --- a/drivers/net/wireless/ath/ath6kl/wmi.c
> +++ b/drivers/net/wireless/ath/ath6kl/wmi.c
> @@ -776,8 +776,10 @@ int ath6kl_wmi_set_roam_lrssi_cmd(struct wmi *wmi, u8 lrssi)
> cmd->info.params.roam_rssi_floor = DEF_LRSSI_ROAM_FLOOR;
> cmd->roam_ctrl = WMI_SET_LRSSI_SCAN_PARAMS;
>
> - return ath6kl_wmi_cmd_send(wmi, 0, skb, WMI_SET_ROAM_CTRL_CMDID,
> + ath6kl_wmi_cmd_send(wmi, 0, skb, WMI_SET_ROAM_CTRL_CMDID,
> NO_SYNC_WMIFLAG);
> +
> + return 0;
> }
>
> int ath6kl_wmi_force_roam_cmd(struct wmi *wmi, const u8 *bssid)
> --
> 2.31.1
>

This change does NOTHING as the caller to this function does not even
look at the return value of the call. So the "claim" that this fixed an
an issue is not true. I will keep this revert and fix it up properly by
propagating the error up the stack correctly.

thanks,

greg k-h