Re: [PATCH 116/190] Revert "thunderbolt: property: Fix a NULL pointer dereference"

Greg Kroah-Hartman
2021-04-27T16:52:53Z

On Thu, Apr 22, 2021 at 06:26:23AM +1000, James Morris wrote:
> On Wed, 21 Apr 2021, Greg Kroah-Hartman wrote:
>
> > This reverts commit 106204b56f60abf1bead7dceb88f2be3e34433da.
> >
> > Commits from @umn.edu addresses have been found to be submitted in "bad
> > faith" to try to test the kernel community's ability to review "known
> > malicious" changes. The result of these submissions can be found in a
> > paper published at the 42nd IEEE Symposium on Security and Privacy
> > entitled, "Open Source Insecurity: Stealthily Introducing
> > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > of Minnesota) and Kangjie Lu (University of Minnesota).
> >
> > Because of this, all submissions from this group must be reverted from
> > the kernel tree and will need to be re-reviewed again to determine if
> > they actually are a valid fix. Until that work is complete, remove this
> > change to ensure that no problems are being introduced into the
> > codebase.
> >
> > Cc: Kangjie Lu <kjlu@umn.edu>
> > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> > drivers/thunderbolt/property.c | 5 -----
> > 1 file changed, 5 deletions(-)
>
> The original patch looks correct.
>
>
> Reviewed-by: James Morris <jamorris@linux.microsoft.com>

Thanks for the review, now dropping this revert.

greg k-h