Re: [PATCH 034/190] Revert "efi/esrt: Fix reference count leak in esre_create_sysfs_entry."

Greg Kroah-Hartman
2021-04-27T16:39:38Z

On Wed, Apr 21, 2021 at 02:58:29PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit 4ddf4739be6e375116c375f0a68bf3893ffcee21.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes. The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix. Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
>
> Cc: Qiushi Wu <wu000273@umn.edu>
> Cc: https
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/firmware/efi/esrt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
> index d5915272141f..e3d692696583 100644
> --- a/drivers/firmware/efi/esrt.c
> +++ b/drivers/firmware/efi/esrt.c
> @@ -181,7 +181,7 @@ static int esre_create_sysfs_entry(void *esre, int entry_num)
> rc = kobject_init_and_add(&entry->kobj, &esre1_ktype, NULL,
> "entry%d", entry_num);
> if (rc) {
> - kobject_put(&entry->kobj);
> + kfree(entry);
> return rc;
> }
> }
> --
> 2.31.1
>

Looks correct so I'm dropping the revert.

greg k-h