Re: [PATCH 156/190] Revert "serial: max310x: pass return value of spi_register_driver"

Greg Kroah-Hartman
2021-04-27T13:47:58Z

On Thu, Apr 22, 2021 at 07:28:51AM +0200, Jiri Slaby wrote:
> On 21. 04. 21, 15:00, Greg Kroah-Hartman wrote:
> > This reverts commit 51f689cc11333944c7a457f25ec75fcb41e99410.
> >
> > Commits from @umn.edu addresses have been found to be submitted in "bad
> > faith" to try to test the kernel community's ability to review "known
> > malicious" changes. The result of these submissions can be found in a
> > paper published at the 42nd IEEE Symposium on Security and Privacy
> > entitled, "Open Source Insecurity: Stealthily Introducing
> > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > of Minnesota) and Kangjie Lu (University of Minnesota).
> >
> > Because of this, all submissions from this group must be reverted from
> > the kernel tree and will need to be re-reviewed again to determine if
> > they actually are a valid fix. Until that work is complete, remove this
> > change to ensure that no problems are being introduced into the
> > codebase.
> >
> > Cc: Kangjie Lu <kjlu@umn.edu>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> > drivers/tty/serial/max310x.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c
> > index 1b61d26bb7af..93f69b66b896 100644
> > --- a/drivers/tty/serial/max310x.c
> > +++ b/drivers/tty/serial/max310x.c
> > @@ -1518,10 +1518,10 @@ static int __init max310x_uart_init(void)
> > return ret;
> > #ifdef CONFIG_SPI_MASTER
> > - ret = spi_register_driver(&max310x_spi_driver);
> > + spi_register_driver(&max310x_spi_driver);
> > #endif
> > - return ret;
> > + return 0;
>
> ACK, uart_unregister_driver() is missing in case of error at least.

Many thanks for the review of the two serial driver changes in this
series, I've updated the changelog with the information and added your
acks.

greg k-h