Re: [PATCH 159/190] Revert "ALSA: gus: add a check of the status of snd_ctl_add"

Greg Kroah-Hartman
2021-04-21T16:29:29Z

On Wed, Apr 21, 2021 at 06:28:07PM +0200, Takashi Iwai wrote:
> On Wed, 21 Apr 2021 15:00:34 +0200,
> Greg Kroah-Hartman wrote:
> >
> > This reverts commit 0f25e000cb4398081748e54f62a902098aa79ec1.
> >
> > Commits from @umn.edu addresses have been found to be submitted in "bad
> > faith" to try to test the kernel community's ability to review "known
> > malicious" changes. The result of these submissions can be found in a
> > paper published at the 42nd IEEE Symposium on Security and Privacy
> > entitled, "Open Source Insecurity: Stealthily Introducing
> > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > of Minnesota) and Kangjie Lu (University of Minnesota).
> >
> > Because of this, all submissions from this group must be reverted from
> > the kernel tree and will need to be re-reviewed again to determine if
> > they actually are a valid fix. Until that work is complete, remove this
> > change to ensure that no problems are being introduced into the
> > codebase.
> >
> > Cc: Kangjie Lu <kjlu@umn.edu>
> > Cc: Takashi Iwai <tiwai@suse.de>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> This code change simply adds an error message print out, so it doesn't
> actually fix anything, per se (although the code change itself is
> fine). Feel free to revert.

Many thanks for the reviews!

greg k-h