Re: [PATCH 155/190] Revert "brcmfmac: add a check for the status of usb_register"

Greg Kroah-Hartman
2021-04-27T14:40:01Z

On Wed, Apr 21, 2021 at 03:00:30PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit 42daad3343be4a4e1ee03e30a5f5cc731dadfef5.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes. The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix. Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
>
> Cc: Kangjie Lu <kjlu@umn.edu>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
> index 586f4dfc638b..d2a803fc8ac6 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
> @@ -1586,10 +1586,6 @@ void brcmf_usb_exit(void)
>
> void brcmf_usb_register(void)
> {
> - int ret;
> -
> brcmf_dbg(USB, "Enter\n");
> - ret = usb_register(&brcmf_usbdrvr);
> - if (ret)
> - brcmf_err("usb_register failed %d\n", ret);
> + usb_register(&brcmf_usbdrvr);
> }
> --
> 2.31.1
>

This change was not ok, and did nothing to actually fix the root problem
here. I'll be keeping this revert and will fix it up "properly".

thanks,

greg k-h