Re: [PATCH 071/190] Revert "pppoe: remove redundant BUG_ON() check in pppoe_pernet"

Greg Kroah-Hartman
2021-04-27T17:34:47Z

On Wed, Apr 21, 2021 at 02:59:06PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit 02a896ca84874bbfcedc006303f2951dda89b298.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes. The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix. Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
>
> Cc: Aditya Pakki <pakki001@umn.edu>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/net/ppp/pppoe.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
> index d7f50b835050..803a4fe1ca18 100644
> --- a/drivers/net/ppp/pppoe.c
> +++ b/drivers/net/ppp/pppoe.c
> @@ -119,6 +119,8 @@ static inline bool stage_session(__be16 sid)
>
> static inline struct pppoe_net *pppoe_pernet(struct net *net)
> {
> + BUG_ON(!net);
> +
> return net_generic(net, pppoe_net_id);
> }
>
> --
> 2.31.1
>

THe original here was correct so I'll drop this revert.

greg k-h