Re: [PATCH 099/190] Revert "omapfb: Fix potential NULL pointer dereference in kmalloc"

Greg Kroah-Hartman
2021-04-27T17:35:30Z

On Wed, Apr 21, 2021 at 02:59:34PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit 31fa6e2ae65feed0de10823c5d1eea21a93086c9.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes. The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix. Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
>
> Cc: Aditya Pakki <pakki001@umn.edu>
> Cc: Kangjie Lu <kjlu@umn.edu>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c b/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c
> index 0ae0cab252d3..05d87dcbdd8b 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c
> @@ -100,8 +100,6 @@ static void __init omapdss_omapify_node(struct device_node *node)
>
> new_len = prop->length + strlen(prefix) * num_strs;
> new_compat = kmalloc(new_len, GFP_KERNEL);
> - if (!new_compat)
> - return;
>
> omapdss_prefix_strcpy(new_compat, new_len, prop->value, prop->length);
>
> --
> 2.31.1
>

Original looks correct, I'll drop this revert.

greg k-h