Re: [PATCH 172/190] Revert "net: (cpts) fix a missing check of clk_prepare"

Greg Kroah-Hartman
2021-04-27T18:05:03Z

On Wed, Apr 21, 2021 at 03:00:47PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit 2d822f2dbab7f4c820f72eb8570aacf3f35855bd.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes. The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix. Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
>
> Cc: Kangjie Lu <kjlu@umn.edu>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/net/ethernet/ti/cpts.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
> index 43222a34cba0..60fde1bb9665 100644
> --- a/drivers/net/ethernet/ti/cpts.c
> +++ b/drivers/net/ethernet/ti/cpts.c
> @@ -778,9 +778,7 @@ struct cpts *cpts_create(struct device *dev, void __iomem *regs,
> return ERR_CAST(cpts->refclk);
> }
>
> - ret = clk_prepare(cpts->refclk);
> - if (ret)
> - return ERR_PTR(ret);
> + clk_prepare(cpts->refclk);
>
> cpts->cc.read = cpts_systim_read;
> cpts->cc.mask = CLOCKSOURCE_MASK(32);
> --
> 2.31.1
>

Original looks correct, revert now dropped.

greg k-h