Re: [PATCH 166/190] Revert "infiniband: bnxt_re: qplib: Check the return value of send_message"

Greg Kroah-Hartman
2021-04-27T14:28:57Z

On Wed, Apr 21, 2021 at 07:45:34PM +0530, Devesh Sharma wrote:
> On Wed, Apr 21, 2021 at 7:38 PM Jason Gunthorpe <jgg@nvidia.com> wrote:
> >
> > On Wed, Apr 21, 2021 at 03:00:41PM +0200, Greg Kroah-Hartman wrote:
> > > This reverts commit 94edd87a1c59f3efa6fdf4e98d6d492e6cec6173.
> > >
> > > Commits from @umn.edu addresses have been found to be submitted in "bad
> > > faith" to try to test the kernel community's ability to review "known
> > > malicious" changes. The result of these submissions can be found in a
> > > paper published at the 42nd IEEE Symposium on Security and Privacy
> > > entitled, "Open Source Insecurity: Stealthily Introducing
> > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > > of Minnesota) and Kangjie Lu (University of Minnesota).
> > >
> > > Because of this, all submissions from this group must be reverted from
> > > the kernel tree and will need to be re-reviewed again to determine if
> > > they actually are a valid fix. Until that work is complete, remove this
> > > change to ensure that no problems are being introduced into the
> > > codebase.
> > >
> > > Cc: Aditya Pakki <pakki001@umn.edu>
> > > Cc: Devesh Sharma <devesh.sharma@broadcom.com>
> > > Cc: Jason Gunthorpe <jgg@mellanox.com>
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > ---
> > > drivers/infiniband/hw/bnxt_re/qplib_sp.c | 5 +++--
> > > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > Can't see a reason to revert this one, I re-checked the callers error
> > paths and it looks OK
> >
> > Jason
> Acked-By: Devesh Sharma <devesh.sharma@broadcom.com>

Thanks for the review, I'll drop this as the original looks ok for now.

greg k-h