Re: [PATCH 182/190] Revert "ethtool: fix a missing-check bug"

James Morris
2021-04-21T20:07:47Z

On Wed, 21 Apr 2021, Greg Kroah-Hartman wrote:

> This reverts commit 2bb3207dbbd4d30e96dd0e1c8e013104193bd59c.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes. The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix. Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
>
> Cc: Wenwen Wang <wang6495@umn.edu>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> net/ethtool/ioctl.c | 3 ---
> 1 file changed, 3 deletions(-)

The original patch looks valid and fixes a race.

Reviewed-by: James Morris <jamorris@linux.microsoft.com>

--
James Morris
<jmorris@namei.org>