Re: [PATCH 003/190] Revert "media: sti: Fix reference count leaks"

Pavel Machek
2021-04-29T20:01:18Z

On Wed 2021-04-21 14:57:58, Greg Kroah-Hartman wrote:
> This reverts commit 6f4432bae9f2d12fc1815b5e26cc07e69bcad0df.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes. The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix. Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.

NAK. This fixes minor bug and should not be reverted.
Pavel

> @@ -272,7 +272,6 @@ static unsigned long int hva_hw_get_ip_version(struct hva_dev *hva)
>
> if (pm_runtime_get_sync(dev) < 0) {
> dev_err(dev, "%s failed to get pm_runtime\n", HVA_PREFIX);
> - pm_runtime_put_noidle(dev);
> mutex_unlock(&hva->protect_mutex);
> return -EFAULT;
> }
> @@ -555,7 +554,6 @@ void hva_hw_dump_regs(struct hva_dev *hva, struct seq_file *s)
>
> if (pm_runtime_get_sync(dev) < 0) {
> seq_puts(s, "Cannot wake up IP\n");
> - pm_runtime_put_noidle(dev);
> mutex_unlock(&hva->protect_mutex);
> return;
> }

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html