From: Pavel Machek <pavel@ucw.cz>
To: Tianling Shen <cnsztl@gmail.com>
Cc: "Heiko Stuebner" <heiko@sntech.de>,
"Marty Jones" <mj8263788@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Jensen Huang" <jensenhuang@friendlyarm.com>,
"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"David Bauer" <mail@david-bauer.net>,
"Johan Jonker" <jbx6244@gmail.com>,
"Jagan Teki" <jagan@amarulasolutions.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S
Date: Mon, 26 Apr 2021 13:03:16 +0200 [thread overview]
Message-ID: <20210426110316.GA13974@duo.ucw.cz> (raw)
In-Reply-To: <CAOP2_ThcRMkgSm872q2By=gALoK-qAjq92FtNQkDO999pZR8kg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]
Hi!
> > > > - Fixed format of LED nodes
> > > >
> > > > Changes in v5:
> > > > - Dropped the empty PCIe node
> > > > - Dropped useless `/delete-property/`
> > > > - Renamed LED nodes
> > > >
> > > > [...]
> > >
> > > Applied, thanks!
> > >
> > > [1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S
> > > commit: 1003888415e83e15ddb63d1d96189b4f2c5f1d48
> > > [2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S
> > > commit: db792e9adbf85ffc9d6b0b060ac3c8e3148c8992
> >
> > Sorry for late review, but:
> >
> >
> > + label = "red:sys";
> >
> > This should be red:power based on the discussion in earlier threads.
>
> However based on the introduction from FriendlyELEC[1], this is not
> the "power" lamp...
> "LEDs: 1 x power LED and 3 x GPIO Controlled LED (SYS, LAN, WAN)"
It is always on, and "sys" is not a valid function.
I'd suggest labeling it as "red:power". Feel free to make other
suggestion but lets keep existing functions.
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2021-04-26 11:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 5:16 [PATCH v6 1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S Tianling Shen
2021-03-19 5:16 ` [PATCH v6 2/2] rockchip: rk3399: Add support " Tianling Shen
2021-03-21 19:02 ` [PATCH v6 1/2] dt-bindings: Add doc " Heiko Stuebner
2021-03-22 10:03 ` Heiko Stuebner
2021-04-25 21:33 ` Pavel Machek
2021-04-26 10:39 ` Tianling Shen
2021-04-26 11:03 ` Pavel Machek [this message]
2021-04-26 11:14 ` Tianling Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210426110316.GA13974@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=cnsztl@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=heiko@sntech.de \
--cc=jacek.anaszewski@gmail.com \
--cc=jagan@amarulasolutions.com \
--cc=jbx6244@gmail.com \
--cc=jensenhuang@friendlyarm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mail@david-bauer.net \
--cc=mj8263788@gmail.com \
--cc=robh+dt@kernel.org \
--cc=uwe@kleine-koenig.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox