From: Jason Gunthorpe <jgg@nvidia.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: mike.marciniszyn@cornelisnetworks.com,
dennis.dalessandro@cornelisnetworks.com, dledford@redhat.com,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/hfi1: Remove redundant variable rcd
Date: Tue, 27 Apr 2021 15:19:05 -0300 [thread overview]
Message-ID: <20210427181905.GA3241618@nvidia.com> (raw)
In-Reply-To: <1619346696-46300-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On Sun, Apr 25, 2021 at 06:31:36PM +0800, Jiapeng Chong wrote:
> Variable rcd is being assigned a value from a calculation
> however the variable is never read, so this redundant variable
> can be removed.
>
> Cleans up the following clang-analyzer warning:
>
> drivers/infiniband/hw/hfi1/affinity.c:986:3: warning: Value stored to
> 'rcd' is never read [clang-analyzer-deadcode.DeadStores].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/infiniband/hw/hfi1/affinity.c | 1 -
> 1 file changed, 1 deletion(-)
Applied to for-next, though I also moved the rcd variable into the
only scope that used it.
Jason
prev parent reply other threads:[~2021-04-27 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 10:31 [PATCH] IB/hfi1: Remove redundant variable rcd Jiapeng Chong
2021-04-27 18:19 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210427181905.GA3241618@nvidia.com \
--to=jgg@nvidia.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox