From: Pavel Skripkin <paskripkin@gmail.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Pavel Skripkin <paskripkin@gmail.com>,
syzbot+d9e482e303930fa4f6ff@syzkaller.appspotmail.com
Subject: [PATCH] ext4: fix memory leak in ext4_fill_super
Date: Wed, 28 Apr 2021 20:28:28 +0300 [thread overview]
Message-ID: <20210428172828.12589-1-paskripkin@gmail.com> (raw)
syzbot reported memory leak in ext4 subsyetem.
The problem appears, when thread_stop() call happens
before wake_up_process().
Normally, this data will be freed by
created thread, but if kthread_stop()
returned -EINTR, this data should be freed manually
Reported-by: syzbot+d9e482e303930fa4f6ff@syzkaller.appspotmail.com
Tested-by: syzbot+d9e482e303930fa4f6ff@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
---
fs/ext4/super.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index b9693680463a..9c33e97bd5c5 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -5156,8 +5156,10 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
failed_mount3:
flush_work(&sbi->s_error_work);
del_timer_sync(&sbi->s_err_report);
- if (sbi->s_mmp_tsk)
- kthread_stop(sbi->s_mmp_tsk);
+ if (sbi->s_mmp_tsk) {
+ if (kthread_stop(sbi->s_mmp_tsk) == -EINTR)
+ kfree(kthread_data(sbi->s_mmp_tsk));
+ }
failed_mount2:
rcu_read_lock();
group_desc = rcu_dereference(sbi->s_group_desc);
--
2.31.1
next reply other threads:[~2021-04-28 17:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 17:28 Pavel Skripkin [this message]
2021-04-29 10:01 ` [PATCH] ext4: fix memory leak in ext4_fill_super Vegard Nossum
2021-04-29 11:08 ` Pavel Skripkin
2021-04-29 11:33 ` Pavel Skripkin
2021-04-29 17:05 ` Theodore Ts'o
2021-04-29 19:20 ` Pavel Skripkin
2021-04-29 20:09 ` Pavel Skripkin
2021-04-29 21:41 ` Theodore Ts'o
2021-04-29 22:05 ` Pavel Skripkin
2021-04-30 3:44 ` Theodore Ts'o
2021-04-30 18:50 ` [PATCH v2] " Pavel Skripkin
2021-05-17 13:40 ` Pavel Skripkin
2021-05-17 18:34 ` Pavel Skripkin
2021-06-05 12:52 ` [RESEND PATCH " Pavel Skripkin
2021-06-17 1:15 ` [PATCH " Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210428172828.12589-1-paskripkin@gmail.com \
--to=paskripkin@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+d9e482e303930fa4f6ff@syzkaller.appspotmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox