From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Rob Herring <robh@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] dt-binding: interrupt-controller: Add missing interrupts property
Date: Thu, 29 Apr 2021 00:41:53 +0200 [thread overview]
Message-ID: <20210428224153.GA15709@alpha.franken.de> (raw)
In-Reply-To: <1619648109.762240.4061025.nullmailer@robh.at.kernel.org>
On Wed, Apr 28, 2021 at 05:15:09PM -0500, Rob Herring wrote:
> On Wed, 28 Apr 2021 00:42:00 +0200, Thomas Bogendoerfer wrote:
> > Interrupts property is required, so add it.
> >
> > Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> > ---
> > .../bindings/interrupt-controller/idt,32434-pic.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.example.dt.yaml: interrupt-controller@1c20400: 'oneOf' conditional failed, one must be fixed:
> 'interrupts' is a required property
> 'interrupts-extended' is a required property
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.yaml
now I'm confused... is this a problem of your test ? make dt_binding_check
was ok with that change...
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2021-04-28 22:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 22:42 [PATCH] dt-binding: interrupt-controller: Add missing interrupts property Thomas Bogendoerfer
2021-04-28 22:15 ` Rob Herring
2021-04-28 22:41 ` Thomas Bogendoerfer [this message]
2021-04-28 23:45 ` Rob Herring
2021-04-29 20:59 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210428224153.GA15709@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox